-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-7253] Added mobile native docs #400
Conversation
…cy NET MAUI docs.
…started on iOS.
No New Or Fixed Issues Found |
Co-authored-by: Katherine Bertelsen <[email protected]>
Deploying contributing-docs with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big PR so I did a quick scan. I stopped commenting on the headers -- please get all of them.
[DataState](https://github.com/bitwarden/android/blob/main/app/src/main/java/com/x8bit/bitwarden/data/platform/repository/model/DataState.kt) | ||
wrapper. | ||
|
||
### Note on Dependency Injection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎨 Make this an actual note or info block where appropriate.
@@ -4,8 +4,92 @@ sidebar_position: 1 | |||
|
|||
# iOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Is there not an Android version of this guide available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's but we discussed it in Slack and it's going to be handled in a different PR by @patrick-bitwarden so we keep author attribution for the docs. Or he could add it directly in this PR if you think is better instead of splitting it.
Co-authored-by: Matt Bishop <[email protected]>
Co-authored-by: Matt Bishop <[email protected]>
Co-authored-by: Matt Bishop <[email protected]>
Co-authored-by: Matt Bishop <[email protected]>
Co-authored-by: Matt Bishop <[email protected]>
Co-authored-by: Matt Bishop <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enough ⛏️s from me -- ship it!
The base branch was changed.
# Conflicts: # docs/architecture/mobile-clients/android/index.md # docs/architecture/mobile-clients/ios/index.md # docs/architecture/mobile-clients/net-maui-legacy/index.mdx # docs/architecture/mobile-clients/net-maui-legacy/overview.md # docs/architecture/mobile-clients/net-maui-legacy/watchOS.md # docs/getting-started/mobile/android/index.md # docs/getting-started/mobile/ios/index.md # docs/getting-started/mobile/net-maui-legacy/android/index.md # docs/getting-started/mobile/net-maui-legacy/index.md # docs/getting-started/mobile/net-maui-legacy/ios/index.mdx # docs/getting-started/mobile/net-maui-legacy/watchos/index.mdx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a rebase.
🎟️ Tracking
PM-7253
📔 Objective
Update docs for the mobile native applications. Includes mobile native architecture and getting started with iOS.
Notes:
Getting started for Android will be handled in a different PR.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes