-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bitwarden.Server.Sdk Tests #85
Conversation
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
=======================================
Coverage 37.06% 37.06%
=======================================
Files 37 37
Lines 1071 1071
Branches 91 91
=======================================
Hits 397 397
Misses 642 642
Partials 32 32 ☔ View full report in Codecov by Sentry. |
Is this still a draft? I also noticed that some docs (per the Sonar results) could be added, but that should be a separate PR. |
@withinfocus Nope, the issues with tests and things still targeting .NET 7 should be fixed. I think most of the things that need documentation are in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎟️ Tracking
📔 Objective
Add some unit tests checking that that various variants of the settings in the SDK can compile or should rightly not compile.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes