Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bitwarden.Server.Sdk Tests #85

Merged
merged 7 commits into from
Jan 29, 2025
Merged

Add Bitwarden.Server.Sdk Tests #85

merged 7 commits into from
Jan 29, 2025

Conversation

justindbaur
Copy link
Member

🎟️ Tracking

📔 Objective

Add some unit tests checking that that various variants of the settings in the SDK can compile or should rightly not compile.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@justindbaur justindbaur requested review from a team as code owners January 28, 2025 13:06
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Logo
Checkmarx One – Scan Summary & Detailsfbe98688-aaf3-4b4a-b284-9dce3c7f9d9d

Great job, no security vulnerabilities found in this Pull Request

@justindbaur justindbaur marked this pull request as draft January 28, 2025 13:40
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.06%. Comparing base (13351c0) to head (8b7833e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage   37.06%   37.06%           
=======================================
  Files          37       37           
  Lines        1071     1071           
  Branches       91       91           
=======================================
  Hits          397      397           
  Misses        642      642           
  Partials       32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@withinfocus
Copy link
Contributor

Is this still a draft?

I also noticed that some docs (per the Sonar results) could be added, but that should be a separate PR.

@justindbaur
Copy link
Member Author

@withinfocus Nope, the issues with tests and things still targeting .NET 7 should be fixed. I think most of the things that need documentation are in Bitwarden.Core which can go away once Bitwarden.Secrets.Sdk gets v2.

@justindbaur justindbaur marked this pull request as ready for review January 28, 2025 17:05
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justindbaur justindbaur merged commit 907ae9c into main Jan 29, 2025
11 checks passed
@justindbaur justindbaur deleted the sdk-tests branch January 29, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants