Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA-965] Adding accesibilityIDs for Manual TOTP entry page elements #1270

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

ifernandezdiaz
Copy link
Contributor

@ifernandezdiaz ifernandezdiaz commented Jan 15, 2025

🎟️ Tracking

📔 Objective

This work is a subtask of QA-947, a story created to group all the native app views that contain elements without Automation IDs.
NOTE: Not all the elements will require an AutomationID. We are adding the ones we currently need so we can reduce the flakiness on some critical Mobile e2e tests

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@ifernandezdiaz ifernandezdiaz changed the title [QA-965] Adding accesibilityIDs for MAnual TOTP entry page elements [QA-965] Adding accesibilityIDs for Manual TOTP entry page elements Jan 15, 2025
Copy link
Contributor

github-actions bot commented Jan 15, 2025

Logo
Checkmarx One – Scan Summary & Details2de28b4f-a2e2-4f3c-b90f-985bb72d56eb

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.47%. Comparing base (8a8fb5e) to head (4866a91).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1270   +/-   ##
=======================================
  Coverage   89.47%   89.47%           
=======================================
  Files         732      732           
  Lines       46144    46146    +2     
=======================================
+ Hits        41286    41288    +2     
  Misses       4858     4858           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ifernandezdiaz ifernandezdiaz merged commit c94cb80 into main Jan 15, 2025
9 checks passed
@ifernandezdiaz ifernandezdiaz deleted the QA-965/add-automationID-totp-view branch January 15, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants