Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Codecov action and removed token #1271

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

mandreko-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/VULN-127

📔 Objective

Codecov updated the codecov/codecov-action GitHub action. In this new version, it no longer requires a CODECOV_TOKEN in the workflows. This PR will update the action to t
he current latest version (5.1.2) and remove the CODECOV_TOKEN for the action.

Note: The codecov/test-results-action GitHub action still requires a token, and can not be removed yet.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@mandreko-bitwarden mandreko-bitwarden requested a review from a team as a code owner January 15, 2025 16:40
Copy link
Contributor

github-actions bot commented Jan 15, 2025

Logo
Checkmarx One – Scan Summary & Details1cbdc4c5-07bf-4e2d-9d84-e3b797f1ee2f

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.46%. Comparing base (c94cb80) to head (97de998).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1271      +/-   ##
==========================================
- Coverage   89.46%   89.46%   -0.01%     
==========================================
  Files         732      732              
  Lines       46150    46150              
==========================================
- Hits        41287    41286       -1     
- Misses       4863     4864       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mandreko-bitwarden mandreko-bitwarden merged commit ac377f3 into main Jan 15, 2025
9 checks passed
@mandreko-bitwarden mandreko-bitwarden deleted the tokenless-codecov branch January 15, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants