-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-16142: Guided Tour for Generator screen #1301
Conversation
… generator screen
…pshot tests for generator guided tour
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1301 +/- ##
==========================================
+ Coverage 89.51% 89.58% +0.06%
==========================================
Files 747 748 +1
Lines 46746 46910 +164
==========================================
+ Hits 41845 42024 +179
+ Misses 4901 4886 -15 ☔ View full report in Codecov by Sentry. |
Great job, no security vulnerabilities found in this Pull Request |
BitwardenShared/UI/Platform/Application/Views/GuidedTourView/GuidedTourView.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Platform/Application/Support/Localizations/en.lproj/Localizable.strings
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Platform/Application/Extensions/View+GuidedTourStep.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Platform/Application/Extensions/View+OnSizeChanged.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Platform/Application/Extensions/View+OnSizeChanged.swift
Show resolved
Hide resolved
BitwardenShared/UI/Tools/Generator/Generator/GeneratorState.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Tools/Generator/Generator/GeneratorView.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Tools/Generator/Generator/GeneratorView.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Platform/Application/Support/Localizations/en.lproj/Localizable.strings
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Platform/Application/Support/Localizations/en.lproj/Localizable.strings
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Platform/Application/Views/GuidedTourView/GuidedTourViewTests.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Tools/Generator/Generator/GeneratorState.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Tools/Generator/Generator/GeneratorView.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Platform/Application/Views/GuidedTourView/GuidedTourViewLoginTests.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Platform/Application/Appearance/Modifiers/SmoothTransitionModifier.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Platform/Application/Views/GuidedTourView/GuidedTourView.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 although I'd wait for @matt-livefront approval as well before merging in case I've missed something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
🎟️ Tracking
PM-16142
PM-16143
PM-16144
PM-16145
PM-16146
PM-16147
📔 Objective
📸 Screenshots
Figma animation
new animation
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-01-30.at.19.31.59.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes