Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-16142: Guided Tour for Generator screen #1301

Merged
merged 14 commits into from
Feb 3, 2025

Conversation

ezimet-livefront
Copy link
Collaborator

@ezimet-livefront ezimet-livefront commented Jan 25, 2025

🎟️ Tracking

PM-16142
PM-16143
PM-16144
PM-16145
PM-16146
PM-16147

📔 Objective

  • Adds guided tour view for generator screen.
  • Fixes a calculation bug for guided tour view.
  • Adds animation to guided tour view transition.

📸 Screenshots

Figma animation

new animation

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-01-30.at.19.31.59.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 97.25086% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.58%. Comparing base (f5c0874) to head (641081d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lication/Views/GuidedTourView/GuidedTourView.swift 95.08% 6 Missing ⚠️
...d/UI/Tools/Generator/Generator/GeneratorView.swift 98.38% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1301      +/-   ##
==========================================
+ Coverage   89.51%   89.58%   +0.06%     
==========================================
  Files         747      748       +1     
  Lines       46746    46910     +164     
==========================================
+ Hits        41845    42024     +179     
+ Misses       4901     4886      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 25, 2025

Logo
Checkmarx One – Scan Summary & Details3486b32a-e218-4b71-82a9-b896f549cbf9

Great job, no security vulnerabilities found in this Pull Request

Copy link
Member

@fedemkr fedemkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 although I'd wait for @matt-livefront approval as well before merging in case I've missed something.

Copy link
Collaborator

@matt-livefront matt-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ezimet-livefront ezimet-livefront merged commit a29f941 into main Feb 3, 2025
9 checks passed
@ezimet-livefront ezimet-livefront deleted the PM-16142/coachmark-generator branch February 3, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants