Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRE-540 - Update Crowdin Sync workflow to use GitHub App #3454

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

vgrassia
Copy link
Member

@vgrassia vgrassia commented Jan 6, 2025

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

This PR changes the logic in the Crowdin Sync workflow in order to check out the repository using our GitHub App instead of the default GitHub Actions token.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@vgrassia vgrassia self-assigned this Jan 6, 2025
@vgrassia vgrassia requested a review from a team as a code owner January 6, 2025 18:27
@vgrassia vgrassia enabled auto-merge (squash) January 6, 2025 18:31
@vgrassia vgrassia disabled auto-merge January 6, 2025 19:56
@vgrassia vgrassia merged commit 7f8b19a into main Jan 6, 2025
3 of 4 checks passed
@vgrassia vgrassia deleted the bre-540_fix-crowdin-workflow branch January 6, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants