Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled SonarQube scanning for PRs #97

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

mandreko-bitwarden
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/VULN-193

๐Ÿ“” Objective

This is to enable SonarQube scanning in PRs, and not just the main/master branches.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@mandreko-bitwarden mandreko-bitwarden requested a review from a team as a code owner February 5, 2025 19:08
Copy link

github-actions bot commented Feb 5, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ c94d49d6-a898-4c66-a865-b86eb31f0d86

Great job, no security vulnerabilities found in this Pull Request

@mandreko-bitwarden mandreko-bitwarden self-assigned this Feb 10, 2025
@mark-youssef-bitwarden mark-youssef-bitwarden merged commit 59f1e2d into main Feb 19, 2025
5 checks passed
@mark-youssef-bitwarden mark-youssef-bitwarden deleted the sonar-pr-scanning branch February 19, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants