Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy ciphers #100

Closed
wants to merge 1 commit into from
Closed

Remove legacy ciphers #100

wants to merge 1 commit into from

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Jan 1, 2025

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

This PR removes legacy ciphers types 0 and 1. Especially 0 is too dangerous to have in production code. Migration can be done via the web clients which will have the cipher type specifically enabled for legacy migration, but nothing else.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@quexten quexten closed this Jan 1, 2025
Copy link
Contributor

github-actions bot commented Jan 1, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ fefa5ef5-c8b1-4e9d-ba9e-0717d1cbeb5e

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant