Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 1.84 MSRV-aware resolution #111

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

dani-garcia
Copy link
Member

@dani-garcia dani-garcia commented Jan 10, 2025

🎟️ Tracking

📔 Objective

Rust 1.84.0 includes opt-in MSRV-aware version resolution, which ensures cargo update won't try to update a package to a MSRV-incompatible version.

Currently we have one package (cargo-platform) that can't be updated to the latest version as it's not compatible with our MSRV. Enabling MSRV-aware version resolution ensures that it won't be updated.

A test of it working:

# Running cargo update will update everything to the latest MSRV-compatible version
% cargo update
    Updating crates.io index
     Locking 31 packages to latest Rust 1.75 compatible versions
    Updating anyhow v1.0.94 -> v1.0.95
    Updating bitflags v2.6.0 -> v2.7.0
    Updating cc v1.2.4 -> v1.2.7
    <..... A few other packages ....>
note: pass `--verbose` to see 5 unchanged dependencies behind latest

# If we disable the MSRV-aware version resolution and run update again, we now get the MSRV incompatible update
% CARGO_RESOLVER_INCOMPATIBLE_RUST_VERSIONS=allow cargo update
    Updating crates.io index
     Locking 1 package to latest compatible version
    Updating cargo-platform v0.1.8 -> v0.1.9
note: pass `--verbose` to see 4 unchanged dependencies behind latest

Depends on #112 to fix some lint issues

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jan 10, 2025

Logo
Checkmarx One – Scan Summary & Detailsd46d846d-75d9-4c14-aeab-e8d61dea866b

No New Or Fixed Issues Found

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.34%. Comparing base (6ee709e) to head (95729ae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   65.34%   65.34%           
=======================================
  Files         180      180           
  Lines       13801    13801           
=======================================
  Hits         9018     9018           
  Misses       4783     4783           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dani-garcia dani-garcia marked this pull request as ready for review January 10, 2025 11:33
@Hinton
Copy link
Member

Hinton commented Jan 10, 2025

About time we got MSRV aware resolution!

@dani-garcia dani-garcia merged commit 73747b6 into main Jan 10, 2025
39 checks passed
@dani-garcia dani-garcia deleted the ps/msrv-aware-resolution branch January 10, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants