PM-13335 - Pin Rust toolchains and introduce Renovate #117
Conversation
|
Great job, no security vulnerabilities found in this Pull Request |
|
|
||
| # The following is not part of the rust-toolchain.toml format, | ||
| # but is used by our Renovate config to manage nightly versions. | ||
| nightly-channel = "nightly-2025-01-01" |
There was a problem hiding this comment.
nightly-channel isn't technically a part of the rust-toolchain file format, but this seemed like a convenient place to put the nightly toolchain.
I tested to see if this breaks anything, but things like rustup show and rustup +nightly show worked fine. Not sure if there are any other tools that would be bothered with the nightly field being here. If so, I'm open to suggestions on where we declare the nightly toolchain.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
=======================================
Coverage 65.24% 65.24%
=======================================
Files 181 181
Lines 13821 13821
=======================================
Hits 9018 9018
Misses 4803 4803 ☔ View full report in Codecov by Sentry. |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13335
📔 Objective
Pin our Rust and Rust nightly toolchains and manage dependency updates with Renovate. This will depend on the changes in bitwarden/renovate-config/pull/17.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes