Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps]: Update rust-wasm-bindgen monorepo #121

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 20, 2025

This PR contains the following updates:

Package Type Update Change
js-sys (source) dependencies patch 0.3.76 -> 0.3.77
wasm-bindgen (source) dependencies patch =0.2.99 -> =0.2.100
wasm-bindgen-futures (source) dependencies patch 0.4.49 -> 0.4.50
wasm-bindgen-futures (source) workspace.dependencies patch 0.4.49 -> 0.4.50
wasm-bindgen-test dev-dependencies patch 0.3.49 -> 0.3.50

Release Notes

rustwasm/wasm-bindgen (wasm-bindgen)

v0.2.100

Compare Source

Released 2025-01-12

Added
  • Add attributes to overwrite return (``unchecked_return_type) and parameter types (unchecked_param_type), descriptions (return_descriptionandparam_description) as well as parameter names (js_name`) for exported functions and methods. See the guide for more details.
    #​4394

  • Add a copy_to_uninit() method to all TypedArrays. It takes &mut [MaybeUninit<T>] and returns &mut [T].
    #​4340

  • Add test coverage support for Node.js.
    #​4348

  • Support importing memory and using wasm_bindgen::module() in Node.js.
    #​4349

  • Add --list, --ignored, --exact and --nocapture to wasm-bindgen-test-runner, analogous to cargo test.
    #​4356

  • Add bindings to Date.to_locale_time_string_with_options.
    #​4384

  • #[wasm_bindgen] now correctly applies #[cfg(...)]s in structs.
    #​4351

Changed
  • Optional parameters are now typed as T | undefined | null to reflect the actual JS behavior.
    #​4188

  • Adding getter, setter, and constructor methods to enums now results in a compiler error. This was previously erroneously allowed and resulted in invalid JS code gen.
    #​4278

  • Handle stuck and failed WebDriver processes when re-trying to start them.
    #​4340

  • Align test output closer to native cargo test.
    #​4358

  • Error if URL in <WEBDRIVER>_REMOTE can't be parsed instead of just ignoring it.
    #​4362

  • Remove WASM_BINDGEN_THREADS_MAX_MEMORY and WASM_BINDGEN_THREADS_STACK_SIZE. The maximum memory size can be set via -Clink-arg=--max-memory=<size>. The stack size of a thread can be set when initializing the thread via the default function.
    #​4363

  • console.*() calls in tests are now always intercepted by default. To show them use --nocapture. When shown they are always printed in-place instead of after test results, analogous to cargo test.
    #​4356

Fixed
  • Fixed using JavaScript keyword as identifiers not being handled correctly.
    #​4329

    • Using JS keywords as struct and enum names will now error at compile time, instead of causing invalid JS code gen.
    • Using JS keywords that are not valid to call or access properties on will now error at compile time, instead of causing invalid JS code gen if used as:
      1. The first part of a js_namespace on imports.
      2. The name of an imported type or constant if the type or constant does not have a js_namespace or module attribute.
      3. The name of an imported function if the function is not a method and does not have a js_namespace or module attribute.
    • Using JS keywords on imports in places other than the above will no longer cause the keywords to be escaped as _{keyword}.
  • Fixed passing large arrays into Rust failing because of internal memory allocations invalidating the memory buffer.
    #​4353

  • Pass along an ignore attribute to unsupported tests.
    #​4360

  • Use OS provided temporary directory for tests instead of Cargo's target directory.
    #​4361

  • Error if URL in <WEBDRIVER>_REMOTE can't be parsed.
    #​4362

  • Internal functions are now removed instead of invalidly imported if they are unused.
    #​4366

  • Fixed no_std support for all APIs in web-sys.
    #​4378

  • Prevent generating duplicate exports for closure conversions.
    #​4380



Configuration

📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@bitwarden-bot bitwarden-bot changed the title [deps]: Update rust-wasm-bindgen monorepo [PM-17272] [deps]: Update rust-wasm-bindgen monorepo Jan 20, 2025
@bitwarden-bot
Copy link

Internal tracking:

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.25%. Comparing base (bbdf45f) to head (4794c7b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   65.24%   65.25%           
=======================================
  Files         181      181           
  Lines       13821    13815    -6     
=======================================
- Hits         9018     9015    -3     
+ Misses       4803     4800    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot changed the title [PM-17272] [deps]: Update rust-wasm-bindgen monorepo [deps]: Update rust-wasm-bindgen monorepo Jan 20, 2025
@dani-garcia dani-garcia requested a review from a team as a code owner January 20, 2025 10:39
Copy link
Contributor Author

renovate bot commented Jan 20, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details34a195d4-5eb6-4ff1-a10e-19235921db3e

Great job, no security vulnerabilities found in this Pull Request

@dani-garcia
Copy link
Member

Had to update the version of the wasm-bindgen CLI to match the new dependency version, otherwise CI would fail.

@dani-garcia dani-garcia merged commit 0bcdae7 into main Jan 20, 2025
39 checks passed
@dani-garcia dani-garcia deleted the renovate/rust-wasm-bindgen-monorepo branch January 20, 2025 13:18
MGibson1 pushed a commit that referenced this pull request Jan 22, 2025
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [js-sys](https://rustwasm.github.io/wasm-bindgen/)
([source](https://redirect.github.com/rustwasm/wasm-bindgen/tree/HEAD/crates/js-sys))
| dependencies | patch | `0.3.76` -> `0.3.77` |
| [wasm-bindgen](https://rustwasm.github.io/)
([source](https://redirect.github.com/rustwasm/wasm-bindgen)) |
dependencies | patch | `=0.2.99` -> `=0.2.100` |
| [wasm-bindgen-futures](https://rustwasm.github.io/wasm-bindgen/)
([source](https://redirect.github.com/rustwasm/wasm-bindgen/tree/HEAD/crates/futures))
| dependencies | patch | `0.4.49` -> `0.4.50` |
| [wasm-bindgen-futures](https://rustwasm.github.io/wasm-bindgen/)
([source](https://redirect.github.com/rustwasm/wasm-bindgen/tree/HEAD/crates/futures))
| workspace.dependencies | patch | `0.4.49` -> `0.4.50` |
| [wasm-bindgen-test](https://redirect.github.com/rustwasm/wasm-bindgen)
| dev-dependencies | patch | `0.3.49` -> `0.3.50` |

---

### Release Notes

<details>
<summary>rustwasm/wasm-bindgen (wasm-bindgen)</summary>

###
[`v0.2.100`](https://redirect.github.com/rustwasm/wasm-bindgen/blob/HEAD/CHANGELOG.md#02100)

[Compare
Source](https://redirect.github.com/rustwasm/wasm-bindgen/compare/0.2.99...0.2.100)

Released 2025-01-12

##### Added

- Add attributes to overwrite return (\`\`unchecked_return_type`) and
parameter types (`unchecked_param_type`), descriptions
(`return_description`and`param_description`) as well as parameter names
(`js_name\`) for exported functions and methods. See the guide for more
details.

[#&#8203;4394](https://redirect.github.com/rustwasm/wasm-bindgen/pull/4394)

- Add a `copy_to_uninit()` method to all `TypedArray`s. It takes `&mut
[MaybeUninit<T>]` and returns `&mut [T]`.

[#&#8203;4340](https://redirect.github.com/rustwasm/wasm-bindgen/pull/4340)

-   Add test coverage support for Node.js.

[#&#8203;4348](https://redirect.github.com/rustwasm/wasm-bindgen/pull/4348)

- Support importing memory and using `wasm_bindgen::module()` in
Node.js.

[#&#8203;4349](https://redirect.github.com/rustwasm/wasm-bindgen/pull/4349)

- Add `--list`, `--ignored`, `--exact` and `--nocapture` to
`wasm-bindgen-test-runner`, analogous to `cargo test`.

[#&#8203;4356](https://redirect.github.com/rustwasm/wasm-bindgen/pull/4356)

-   Add bindings to `Date.to_locale_time_string_with_options`.

[#&#8203;4384](https://redirect.github.com/rustwasm/wasm-bindgen/pull/4384)

-   `#[wasm_bindgen]` now correctly applies `#[cfg(...)]`s in `struct`s.

[#&#8203;4351](https://redirect.github.com/rustwasm/wasm-bindgen/pull/4351)

##### Changed

- Optional parameters are now typed as `T | undefined | null` to reflect
the actual JS behavior.

[#&#8203;4188](https://redirect.github.com/rustwasm/wasm-bindgen/pull/4188)

- Adding `getter`, `setter`, and `constructor` methods to enums now
results in a compiler error. This was previously erroneously allowed and
resulted in invalid JS code gen.

[#&#8203;4278](https://redirect.github.com/rustwasm/wasm-bindgen/pull/4278)

- Handle stuck and failed WebDriver processes when re-trying to start
them.

[#&#8203;4340](https://redirect.github.com/rustwasm/wasm-bindgen/pull/4340)

-   Align test output closer to native `cargo test`.

[#&#8203;4358](https://redirect.github.com/rustwasm/wasm-bindgen/pull/4358)

- Error if URL in `<WEBDRIVER>_REMOTE` can't be parsed instead of just
ignoring it.

[#&#8203;4362](https://redirect.github.com/rustwasm/wasm-bindgen/pull/4362)

- Remove `WASM_BINDGEN_THREADS_MAX_MEMORY` and
`WASM_BINDGEN_THREADS_STACK_SIZE`. The maximum memory size can be set
via `-Clink-arg=--max-memory=<size>`. The stack size of a thread can be
set when initializing the thread via the `default` function.

[#&#8203;4363](https://redirect.github.com/rustwasm/wasm-bindgen/pull/4363)

- `console.*()` calls in tests are now always intercepted by default. To
show them use `--nocapture`. When shown they are always printed in-place
instead of after test results, analogous to `cargo test`.

[#&#8203;4356](https://redirect.github.com/rustwasm/wasm-bindgen/pull/4356)

##### Fixed

- Fixed using [JavaScript
keyword](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar#keywords)
as identifiers not being handled correctly.

[#&#8203;4329](https://redirect.github.com/rustwasm/wasm-bindgen/pull/4329)

- Using JS keywords as `struct` and `enum` names will now error at
compile time, instead of causing invalid JS code gen.
- Using JS keywords that are not valid to call or access properties on
will now error at compile time, instead of causing invalid JS code gen
if used as:
        1.  The first part of a `js_namespace` on imports.
2. The name of an imported type or constant if the type or constant does
not have a `js_namespace` or `module` attribute.
3. The name of an imported function if the function is not a method and
does not have a `js_namespace` or `module` attribute.
- Using JS keywords on imports in places other than the above will no
longer cause the keywords to be escaped as `_{keyword}`.

<!---->

- Fixed passing large arrays into Rust failing because of internal
memory allocations invalidating the memory buffer.

[#&#8203;4353](https://redirect.github.com/rustwasm/wasm-bindgen/pull/4353)

-   Pass along an `ignore` attribute to `unsupported` tests.

[#&#8203;4360](https://redirect.github.com/rustwasm/wasm-bindgen/pull/4360)

- Use OS provided temporary directory for tests instead of Cargo's
`target` directory.

[#&#8203;4361](https://redirect.github.com/rustwasm/wasm-bindgen/pull/4361)

-   Error if URL in `<WEBDRIVER>_REMOTE` can't be parsed.

[#&#8203;4362](https://redirect.github.com/rustwasm/wasm-bindgen/pull/4362)

- Internal functions are now removed instead of invalidly imported if
they are unused.

[#&#8203;4366](https://redirect.github.com/rustwasm/wasm-bindgen/pull/4366)

-   Fixed `no_std` support for all APIs in `web-sys`.

[#&#8203;4378](https://redirect.github.com/rustwasm/wasm-bindgen/pull/4378)

-   Prevent generating duplicate exports for closure conversions.

[#&#8203;4380](https://redirect.github.com/rustwasm/wasm-bindgen/pull/4380)

***

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every 2nd week starting on the 2 week
of the year before 4am on Monday" (UTC), Automerge - At any time (no
schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config
help](https://redirect.github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/bitwarden/sdk-internal).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMDcuMCIsInVwZGF0ZWRJblZlciI6IjM5LjEwNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel García <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants