[PM-16221] uniffi bindings for ssh agent and keygen #89
Conversation
|
Question for whoever reviews: On both the wasm bindings and here, I put the ssh methods on the global "namespace" directly, since things like cryptoclient seemed to be for holding state. They can also act as namespaces though. Should they be moved under something like "sshclient"? |
quexten
force-pushed
the
km/pm_16221/uniffi-ssh-bindings
branch
from
4a77d22 to
750db94
Compare
|
No New Or Fixed Issues Found |
quexten
force-pushed
the
km/pm_16221/uniffi-ssh-bindings
branch
from
51db1f3 to
4d4c67a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
- Coverage 65.34% 65.24% -0.10%
==========================================
Files 180 181 +1
Lines 13801 13821 +20
==========================================
Hits 9018 9018
- Misses 4783 4803 +20 ☔ View full report in Codecov by Sentry. |
crates/bitwarden-uniffi/src/lib.rs
Outdated
| pub fn generate_ssh_key( | ||
| &self, | ||
| key_algorithm: bitwarden_ssh::generator::KeyAlgorithm, | ||
| ) -> Result<bitwarden_ssh::SshKey> { | ||
| bitwarden_ssh::generator::generate_sshkey(key_algorithm) | ||
| .map_err(|e| error::BitwardenError::E(error::Error::SshGeneration(e))) | ||
| } | ||
|
|
||
| pub fn import_ssh_key( | ||
| &self, | ||
| imported_key: String, | ||
| password: Option<String>, | ||
| ) -> Result<bitwarden_ssh::SshKey> { | ||
| bitwarden_ssh::import::import_key(imported_key, password) | ||
| .map_err(|e| error::BitwardenError::E(error::Error::SshImport(e))) | ||
| } |
There was a problem hiding this comment.
issue: Please make a client for these, we don't want them in the root.
There was a problem hiding this comment.
Updated and moved to a client, should we do the same for wasm in a follow-up pr?
| &self, | ||
| key_algorithm: bitwarden_ssh::generator::KeyAlgorithm, | ||
| ) -> Result<bitwarden_ssh::SshKey> { | ||
| bitwarden_ssh::generator::generate_sshkey(key_algorithm) |
There was a problem hiding this comment.
observation: We would probably benefit from taking a look at the public interface of bitwarden_ssh. Exposing modules is a bit clunky and the library is small enough that re-publishing everything in the root would result in a cleaner interface.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16221
📔 Objective
Adds bindings so we can add keygen and import to the mobile clients.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes