Fix worklfow-linter detected issues in workflows

bitwarden · Jan 24, 2025 · 52ecd6e · 52ecd6e
1 parent 46a6981
commit 52ecd6e
Show file tree

Hide file tree

Showing 11 changed files with 41 additions and 40 deletions.
diff --git a/.github/workflows/publish-bws.yml b/.github/workflows/publish-bws.yml
@@ -26,9 +26,9 @@ jobs:
     name: Setup
     runs-on: ubuntu-22.04
     outputs:
-      release-version: ${{ steps.version-output.outputs.version }}
-      release-tag: ${{ steps.version-output.outputs.tag_name }}
-      deployment-id: ${{ steps.deployment.outputs.deployment_id }}
+      release_version: ${{ steps.version-output.outputs.version }}
+      release_tag: ${{ steps.version-output.outputs.tag_name }}
+      deployment_id: ${{ steps.deployment.outputs.deployment_id }}
     steps:
       - name: Checkout repo
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -75,8 +75,8 @@ jobs:
     runs-on: ubuntu-22.04
     needs: setup
     env:
-      _VERSION: ${{ needs.setup.outputs.release-version }}
-      _TAG_NAME: ${{ needs.setup.outputs.release-tag }}
+      _VERSION: ${{ needs.setup.outputs.release_version }}
+      _TAG_NAME: ${{ needs.setup.outputs.release_tag }}
     steps:
       - name: Checkout
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -129,7 +129,7 @@ jobs:
       - name: Generate tag list
         id: tag-list
         env:
-          VERSION: ${{ needs.setup.outputs.release-version }}
+          VERSION: ${{ needs.setup.outputs.release_version }}
           DRY_RUN: ${{ inputs.release_type == 'Dry Run' }}
         run: |
           if [[ "${DRY_RUN}" == "true" ]]; then
@@ -228,20 +228,20 @@ jobs:
     needs: setup
     if: ${{ inputs.release_type != 'Dry Run' }}
     env:
-      _DEPLOYMENT_ID: ${{ needs.setup.outputs.deployment-id }}
+      _DEPLOYMENT_ID: ${{ needs.setup.outputs.deployment_id }}
     steps:
       - name: Update deployment status to Success
         if: ${{ inputs.release_type != 'Dry Run' && success() }}
         uses: chrnorm/deployment-status@9a72af4586197112e0491ea843682b5dc280d806 # v2.0.3
         with:
           token: "${{ secrets.GITHUB_TOKEN }}"
           state: "success"
-          deployment-id: ${{ env._DEPLOYMENT_ID }}
+          deployment_id: ${{ env._DEPLOYMENT_ID }}
 
       - name: Update deployment status to Failure
         if: ${{ inputs.release_type != 'Dry Run' && failure() }}
         uses: chrnorm/deployment-status@9a72af4586197112e0491ea843682b5dc280d806 # v2.0.3
         with:
           token: "${{ secrets.GITHUB_TOKEN }}"
           state: "failure"
-          deployment-id: ${{ env._DEPLOYMENT_ID }}
+          deployment_id: ${{ env._DEPLOYMENT_ID }}
diff --git a/.github/workflows/publish-dotnet.yml b/.github/workflows/publish-dotnet.yml
@@ -102,12 +102,12 @@ jobs:
         with:
           token: "${{ secrets.GITHUB_TOKEN }}"
           state: "success"
-          deployment-id: ${{ steps.deployment.outputs.deployment_id }}
+          deployment_id: ${{ steps.deployment.outputs.deployment_id }}
 
       - name: Update deployment status to Failure
         if: ${{ inputs.release_type != 'Dry Run' && failure() }}
         uses: chrnorm/deployment-status@9a72af4586197112e0491ea843682b5dc280d806 # v2.0.3
         with:
           token: "${{ secrets.GITHUB_TOKEN }}"
           state: "failure"
-          deployment-id: ${{ steps.deployment.outputs.deployment_id }}
+          deployment_id: ${{ steps.deployment.outputs.deployment_id }}
diff --git a/.github/workflows/publish-napi.yml b/.github/workflows/publish-napi.yml
@@ -26,8 +26,8 @@ jobs:
     name: Setup
     runs-on: ubuntu-22.04
     outputs:
-      release-version: ${{ steps.version-output.outputs.version }}
-      tag-name: ${{ steps.version-output.outputs.tag_name }}
+      release_version: ${{ steps.version-output.outputs.version }}
+      tag_name: ${{ steps.version-output.outputs.tag_name }}
     steps:
       - name: Checkout repo
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -63,8 +63,8 @@ jobs:
     runs-on: ubuntu-22.04
     needs: setup
     env:
-      _PKG_VERSION: ${{ needs.setup.outputs.release-version }}
-      _TAG_NAME: ${{ needs.setup.outputs.tag-name }}
+      _PKG_VERSION: ${{ needs.setup.outputs.release_version }}
+      _TAG_NAME: ${{ needs.setup.outputs.tag_name }}
     steps:
       - name: Checkout repo
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -143,12 +143,12 @@ jobs:
         with:
           token: "${{ secrets.GITHUB_TOKEN }}"
           state: "success"
-          deployment-id: ${{ steps.deployment.outputs.deployment_id }}
+          deployment_id: ${{ steps.deployment.outputs.deployment_id }}
 
       - name: Update deployment status to Failure
         if: ${{ inputs.release_type != 'Dry Run' && failure() }}
         uses: chrnorm/deployment-status@9a72af4586197112e0491ea843682b5dc280d806 # v2.0.3
         with:
           token: "${{ secrets.GITHUB_TOKEN }}"
           state: "failure"
-          deployment-id: ${{ steps.deployment.outputs.deployment_id }}
+          deployment_id: ${{ steps.deployment.outputs.deployment_id }}
diff --git a/.github/workflows/publish-ruby.yml b/.github/workflows/publish-ruby.yml
@@ -26,8 +26,8 @@ jobs:
     name: Setup
     runs-on: ubuntu-22.04
     outputs:
-      release-version: ${{ steps.version-output.outputs.version }}
-      tag-name: ${{ steps.version-output.outputs.tag_name }}
+      release_version: ${{ steps.version-output.outputs.version }}
+      tag_name: ${{ steps.version-output.outputs.tag_name }}
     steps:
       - name: Checkout Repository
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -63,8 +63,8 @@ jobs:
     runs-on: ubuntu-22.04
     needs: setup
     env:
-      _VERSION: ${{ needs.setup.outputs.release-version }}
-      _TAG_NAME: ${{ needs.setup.outputs.tag-name }}
+      _VERSION: ${{ needs.setup.outputs.release_version }}
+      _TAG_NAME: ${{ needs.setup.outputs.tag_name }}
     steps:
       - name: Checkout Repository
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -115,12 +115,12 @@ jobs:
         with:
           token: "${{ secrets.GITHUB_TOKEN }}"
           state: "success"
-          deployment-id: ${{ steps.deployment.outputs.deployment_id }}
+          deployment_id: ${{ steps.deployment.outputs.deployment_id }}
 
       - name: Update deployment status to Failure
         if: ${{ inputs.release_type != 'Dry Run' && failure() }}
         uses: chrnorm/deployment-status@9a72af4586197112e0491ea843682b5dc280d806 # v2.0.3
         with:
           token: "${{ secrets.GITHUB_TOKEN }}"
           state: "failure"
-          deployment-id: ${{ steps.deployment.outputs.deployment_id }}
+          deployment_id: ${{ steps.deployment.outputs.deployment_id }}
diff --git a/.github/workflows/publish-rust-crates.yml b/.github/workflows/publish-rust-crates.yml
@@ -21,11 +21,11 @@ on:
 
 jobs:
   setup:
-    name: setup
+    name: Setup
     runs-on: ubuntu-22.04
     outputs:
-      release-version: ${{ steps.version-output.outputs.version }}
-      release-tag: ${{ steps.version-output.outputs.tag_name }}
+      release_version: ${{ steps.version-output.outputs.version }}
+      release_tag: ${{ steps.version-output.outputs.tag_name }}
     steps:
       - name: Checkout
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -64,7 +64,7 @@ jobs:
       - name: Checkout
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
-          ref: ${{ needs.setup.outputs.release-tag }}
+          ref: ${{ needs.setup.outputs.release_tag }}
 
       - name: Login to Azure
         uses: Azure/login@e15b166166a8746d1a47596803bd8c1b595455cf # v1.6.0
@@ -113,12 +113,12 @@ jobs:
         with:
           token: "${{ secrets.GITHUB_TOKEN }}"
           state: "success"
-          deployment-id: ${{ steps.deployment.outputs.deployment_id }}
+          deployment_id: ${{ steps.deployment.outputs.deployment_id }}
 
       - name: Update deployment status to Failure
         if: ${{ inputs.release_type != 'Dry Run' && failure() }}
         uses: chrnorm/deployment-status@9a72af4586197112e0491ea843682b5dc280d806 # v2.0.3
         with:
           token: "${{ secrets.GITHUB_TOKEN }}"
           state: "failure"
-          deployment-id: ${{ steps.deployment.outputs.deployment_id }}
+          deployment_id: ${{ steps.deployment.outputs.deployment_id }}
diff --git a/.github/workflows/publish-wasm.yml b/.github/workflows/publish-wasm.yml
@@ -26,7 +26,7 @@ jobs:
     name: Setup
     runs-on: ubuntu-22.04
     outputs:
-      release-version: ${{ steps.version-output.outputs.version }}
+      release_version: ${{ steps.version-output.outputs.version }}
       tag_name: ${{ steps.version-output.outputs.tag_name }}
     steps:
       - name: Checkout repo
@@ -63,7 +63,7 @@ jobs:
     runs-on: ubuntu-22.04
     needs: setup
     env:
-      _VERSION: ${{ needs.setup.outputs.release-version }}
+      _VERSION: ${{ needs.setup.outputs.release_version }}
     steps:
       - name: Checkout repo
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -126,12 +126,12 @@ jobs:
         with:
           token: "${{ secrets.GITHUB_TOKEN }}"
           state: "success"
-          deployment-id: ${{ steps.deployment.outputs.deployment_id }}
+          deployment_id: ${{ steps.deployment.outputs.deployment_id }}
 
       - name: Update deployment status to Failure
         if: ${{ inputs.release_type != 'Dry Run' && failure() }}
         uses: chrnorm/deployment-status@9a72af4586197112e0491ea843682b5dc280d806 # v2.0.3
         with:
           token: "${{ secrets.GITHUB_TOKEN }}"
           state: "failure"
-          deployment-id: ${{ steps.deployment.outputs.deployment_id }}
+          deployment_id: ${{ steps.deployment.outputs.deployment_id }}
diff --git a/.github/workflows/release-bws.yml b/.github/workflows/release-bws.yml
@@ -18,7 +18,7 @@ jobs:
     name: Setup
     runs-on: ubuntu-22.04
     outputs:
-      release-version: ${{ steps.version.outputs.version }}
+      release_version: ${{ steps.version.outputs.version }}
     steps:
       - name: Checkout repo
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

diff --git a/.github/workflows/release-napi.yml b/.github/workflows/release-napi.yml
@@ -41,7 +41,7 @@ jobs:
 
       - name: Check Release Version
         id: version
-        uses: bitwarden/gh-actions/release-version-check@main
+        uses: bitwarden/gh-actions/release_version-check@main
         with:
           release-type: ${{ inputs.release_type }}
           project-type: ts

diff --git a/.github/workflows/release-rust-crates.yml b/.github/workflows/release-rust-crates.yml
@@ -18,7 +18,7 @@ jobs:
     name: Setup
     runs-on: ubuntu-22.04
     outputs:
-      release-version: ${{ steps.version.outputs.version }}
+      release_version: ${{ steps.version.outputs.version }}
     steps:
       - name: Checkout repo
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

diff --git a/.github/workflows/release-wasm.yml b/.github/workflows/release-wasm.yml
@@ -22,7 +22,7 @@ jobs:
     name: Setup
     runs-on: ubuntu-22.04
     outputs:
-      release-version: ${{ steps.version.outputs.version }}
+      release_version: ${{ steps.version.outputs.version }}
     steps:
       - name: Checkout repo
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -39,7 +39,7 @@ jobs:
 
       - name: Check Release Version
         id: version
-        uses: bitwarden/gh-actions/release-version-check@main
+        uses: bitwarden/gh-actions/release_version-check@main
         with:
           release-type: ${{ inputs.release_type }}
           project-type: ts
@@ -66,7 +66,7 @@ jobs:
         if: ${{ inputs.release_type != 'Dry Run' }}
         uses: ncipollo/release-action@2c591bcc8ecdcd2db72b97d6147f871fcd833ba5 # v1.14.0
         env:
-          PKG_VERSION: ${{ needs.setup.outputs.release-version }}
+          PKG_VERSION: ${{ needs.setup.outputs.release_version }}
         with:
           commit: ${{ github.sha }}
           tag: wasm-v${{ env.PKG_VERSION }}

diff --git a/.github/workflows/rust-test.yml b/.github/workflows/rust-test.yml
@@ -18,7 +18,8 @@ jobs:
       - test
       - wasm
     steps:
-      - run: exit 0
+      - name: Exit 0
+        run: exit 0
 
   test:
     name: ${{ matrix.os }} / default