Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Sensitive::test behind flag #764

Merged
merged 2 commits into from
May 3, 2024
Merged

Hide Sensitive::test behind flag #764

merged 2 commits into from
May 3, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented May 3, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Hide Sensitive::test behind a feature flag which is only added as a dev-dependency.

Before you submit

  • Please add unit tests where it makes sense to do so

@Hinton Hinton requested a review from dani-garcia May 3, 2024 10:45
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.72%. Comparing base (7e57f19) to head (5558dcd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #764   +/-   ##
=======================================
  Coverage   58.72%   58.72%           
=======================================
  Files         177      177           
  Lines       11501    11501           
=======================================
  Hits         6754     6754           
  Misses       4747     4747           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 3, 2024

Logo
Checkmarx One – Scan Summary & Details587d6cac-b468-4400-ba18-2457bf771f0a

No New Or Fixed Issues Found

Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

About the memory leak test, I've made some changes to the testing framework in this PR #766, and with those changes the test passes again (CI run here: #768)

I think it is indeed related to the debug builds code generation, as that PR is changing the test to use release builds. I'm not quite sure what part of this PR is triggering the Rust compiler to generate different code than before though.

Edit: I've merged the changes in main and it's working now! 🚀

@Hinton Hinton merged commit 27cdb63 into main May 3, 2024
78 checks passed
@Hinton Hinton deleted the ps/sensitive-test branch May 3, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants