Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passkey iOS example #767

Merged
merged 10 commits into from
May 3, 2024
Merged

Passkey iOS example #767

merged 10 commits into from
May 3, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented May 3, 2024 •
edited
Loading

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Quick. example of how to use the Passkey APIs on iOS. Android should be mostly the same.

Before you submit

  • Please add unit tests where it makes sense to do so

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 3d6d06d6-f2b0-48aa-b1ee-4599acbcb4d9

No New Or Fixed Issues Found

@codecov Codecov
Copy link

codecov bot commented May 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.75%. Comparing base (a2495b7) to head (fe8cc92).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
- Coverage   61.74%   58.75%   -3.00%     
==========================================
  Files         173      177       +4     
  Lines       10934    11501     +567     
==========================================
+ Hits         6751     6757       +6     
- Misses       4183     4744     +561

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton changed the title Passkey Uniffi API layer Passkey iOS example May 3, 2024
@Hinton Hinton requested a review from dani-garcia May 3, 2024 12:58
@Hinton Hinton marked this pull request as ready for review May 3, 2024 12:58
dani-garcia
dani-garcia previously approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, how did you format this code? I couldn't get Xcode to do it for me when I wrote it 😭

languages/swift/iOS/App/ContentView.swift Show resolved Hide resolved
@Hinton
Copy link
Member Author

Hinton commented May 3, 2024

Format, brew install swiftlint, swiftlint --fix`

Base automatically changed from ps/passkeys-interface-mock to main May 3, 2024 15:35
@Hinton Hinton dismissed dani-garcia’s stale review May 3, 2024 15:35

The base branch was changed.

@Hinton
Merge branch 'main' of github.com:bitwarden/sdk into ps/passkey-ios
fe8cc92 
# Conflicts:
#	crates/bitwarden-uniffi/src/error.rs
#	crates/bitwarden-uniffi/src/platform/fido2.rs
#	crates/bitwarden/src/platform/client_platform.rs
@Hinton Hinton requested a review from dani-garcia May 3, 2024 15:37
@Hinton Hinton merged commit b36cf6f into main May 3, 2024
77 checks passed
@Hinton Hinton deleted the ps/passkey-ios branch May 3, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dani-garcia dani-garcia dani-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hinton @dani-garcia