Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change where we transform UV #786

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented May 15, 2024

No description provided.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details0e199d11-7b8b-41e1-84c6-d2cad436a5e1

No New Or Fixed Issues Found

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 57.39%. Comparing base (3a03ba5) to head (807d907).

Files Patch % Lines
...ates/bitwarden/src/platform/fido2/authenticator.rs 0.00% 9 Missing ⚠️
crates/bitwarden/src/platform/fido2/types.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##           ps/uniffi-passkey-improvements     #786   +/-   ##
===============================================================
  Coverage                           57.38%   57.39%           
===============================================================
  Files                                 179      179           
  Lines                               11926    11925    -1     
===============================================================
  Hits                                 6844     6844           
+ Misses                               5082     5081    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dani-garcia dani-garcia merged commit 2832bcf into ps/uniffi-passkey-improvements May 15, 2024
91 checks passed
@dani-garcia dani-garcia deleted the ps/uniffi-passkey-improvements-uv-transfor branch May 15, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants