[PM-11162] Assign to Collection Permission Update #4844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues (171)Checkmarx found the following issues in this Pull Request
Fixed Issues (7)Great job! The following issues were fixed in this Pull Request
|
shane-melton
requested changes
Oct 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4844 +/- ##
==========================================
- Coverage 44.24% 44.22% -0.02%
==========================================
Files 1492 1492
Lines 68841 68869 +28
Branches 6199 6203 +4
==========================================
Hits 30456 30456
- Misses 37066 37094 +28
Partials 1319 1319 ☔ View full report in Codecov by Sentry. |
shane-melton
previously approved these changes
Oct 7, 2024
shane-melton
requested changes
Nov 6, 2024
| [Reprompt], | ||
| [Key], | ||
| [OrganizationUseTotp] | ||
| , MAX ([Edit]) AS [Edit] |
There was a problem hiding this comment.
⛏️ Can we fix the formatting here so that the , comes at the end of each line (to match the rest)?
| [Reprompt], | ||
| [Key], | ||
| [OrganizationUseTotp] | ||
|
|
There was a problem hiding this comment.
⛏️ Extra whitespace we can remove
There was a problem hiding this comment.
🎨 We'll want to update the date in this migration script to todays date since we already have a few others on main with a more recent date.
shane-melton
previously approved these changes
Nov 6, 2024
shane-melton
previously approved these changes
Dec 11, 2024
|
After speaking with product and design we have decided to move away from hiding |
shane-melton
previously approved these changes
Jan 8, 2025
shane-melton
approved these changes
Feb 4, 2025
|
rkac-bw
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-11162
📔 Objective
Users with
Can Edit Except Passwordwill not be allowed to assign collections to ciphers.Updates made to
CipherDetails_ReadByIdUserId.sqlto get accurateViewPasswordvalue when user assigns/unassigns collections (This addresses bug PM-14046)NOTE: EntityFramework update being looked at later on.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes