Auth/pm 2996/add auth request data to devices response model

[Patrick-Pimentel-Bitwarden]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-2996

📔 Objective

This pr adds two new fields to the get devices response endpoint. Now we respond back with the pending auth requests that match a certain criteria when retrieving devices.

A details object was used to separate the response from the controller from the data coming back from the database.

Also updated .github/workflows/test-database.yml with a more descriptive error message to assist in debugging.

📸 Screenshots

old_response.mov

new_response.mov

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 36.91275% with 94 lines in your changes missing coverage. Please review.

Project coverage is 43.85%. Comparing base (1062c6d) to head (474bdee).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/Core/Auth/Models/Data/DeviceAuthDetails.cs	28.81%	41 Missing and 1 partial ⚠️
...ries/Queries/DeviceWithPendingAuthByUserIdQuery.cs	0.00%	24 Missing ⚠️
...astructure.Dapper/Repositories/DeviceRepository.cs	0.00%	17 Missing ⚠️
...e.EntityFramework/Repositories/DeviceRepository.cs	27.27%	8 Missing ⚠️
...c/Infrastructure.Dapper/Repositories/Repository.cs	0.00%	2 Missing ⚠️
...els/Api/Response/DeviceAuthRequestResponseModel.cs	96.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5152      +/-   ##
==========================================
+ Coverage   43.34%   43.85%   +0.50%     
==========================================
  Files        1458     1470      +12     
  Lines       66517    67763    +1246     
  Branches     6081     6117      +36     
==========================================
+ Hits        28835    29720     +885     
- Misses      36390    36748     +358     
- Partials     1292     1295       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – 0a578e05-084d-4663-9f08-ec4484c6bd77

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 967	Attack Vector
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 381	Attack Vector
	CSRF	/src/Api/Auth/Controllers/EmergencyAccessController.cs: 159	Attack Vector
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 922	Attack Vector
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 261	Attack Vector
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 749	Attack Vector
	CSRF	/src/Api/Auth/Controllers/TwoFactorController.cs: 406	Attack Vector
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 639	Attack Vector
	CSRF	/src/Api/Auth/Controllers/TwoFactorController.cs: 108	Attack Vector
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 163	Attack Vector
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 503	Attack Vector
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 236	Attack Vector
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 356	Attack Vector
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 482	Attack Vector
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 899	Attack Vector
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 310	Attack Vector
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 483	Attack Vector
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 535	Attack Vector
	CSRF	/src/Api/Controllers/SettingsController.cs: 36	Attack Vector
	CSRF	/src/Api/Controllers/DevicesController.cs: 72	Attack Vector
	Privacy_Violation	/src/Core/NotificationHub/NotificationHubPushNotificationService.cs: 195	Attack Vector
	Privacy_Violation	/src/Api/Vault/Models/Request/CipherRequestModel.cs: 173	Attack Vector
	Privacy_Violation	/src/Api/Vault/Models/Request/CipherRequestModel.cs: 202	Attack Vector
	Log_Forging	/src/Api/Auth/Controllers/AccountsController.cs: 967	Attack Vector
	Log_Forging	/src/Api/Vault/Controllers/CiphersController.cs: 220	Attack Vector
	Log_Forging	/src/Api/Auth/Controllers/AuthRequestsController.cs: 87	Attack Vector
	Log_Forging	/src/Api/Auth/Controllers/AuthRequestsController.cs: 75	Attack Vector
	Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 406	Attack Vector
	Missing_CSP_Header	/src/Core/MailTemplates/Handlebars/AdminConsole/DomainClaimedByOrganization.html.hbs: 5	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 967
	CSRF	/src/Api/AdminConsole/Controllers/PoliciesController.cs: 70
	CSRF	/src/Api/NotificationCenter/Controllers/NotificationsController.cs: 67
	CSRF	/src/Api/NotificationCenter/Controllers/NotificationsController.cs: 61
	CSRF	/src/Api/Billing/Controllers/OrganizationsController.cs: 52
	CSRF	/src/Billing/Controllers/RecoveryController.cs: 38
	CSRF	/src/Api/Auth/Controllers/TwoFactorController.cs: 108
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 922
	CSRF	/src/Billing/Controllers/StripeController.cs: 164
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 639
	CSRF	/src/Api/Controllers/DevicesController.cs: 73
	CSRF	/src/Api/AdminConsole/Controllers/PoliciesController.cs: 91
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 470
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 236
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 261
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 356
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 482
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 899
	CSRF	/src/Api/Auth/Controllers/EmergencyAccessController.cs: 159
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 310
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 483
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 503
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 535
	CSRF	/src/Api/Controllers/SettingsController.cs: 36
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 163
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 381
	CSRF	/src/Api/Auth/Controllers/TwoFactorController.cs: 406
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 749
	Log_Forging	/src/Billing/Controllers/RecoveryController.cs: 38
	Log_Forging	/src/Billing/Controllers/RecoveryController.cs: 38
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164

[ike-kottlowski]

Thanks boss.

[rkac-bw]

lgtm

[addisonbeck]

The workflow change looks fine. I didn't review much else because it seems like that's been covered.

[rkac-bw]

lgtm