[PM-14381] Add POST /tasks/bulk-create endpoint #5188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pper CipherRepository
…rver into vault/PM-14381
rkac-bw
reviewed
Jan 15, 2025
| @@ -0,0 +1,9 @@ | |||
| CREATE TYPE [dbo].[SecurityTaskType] AS TABLE( | |||
| [Id] UNIQUEIDENTIFIER NOT NULL, | |||
There was a problem hiding this comment.
We are trying to avoid custom data types that will need sql changes per schema changes.
The preference is to use the existing generic guidarray for bulk operations
CREATE TYPE [dbo].[GuidIdArray] AS TABLE(
[Id] [uniqueidentifier] NOT NULL
)
shane-melton
requested changes
Jan 28, 2025
src/Sql/Vault/dbo/Stored Procedures/SecurityTask/SecurityTask_CreateMany.sql
Show resolved
Hide resolved
|
|
||
| public class SecurityTaskCreateRequest | ||
| { | ||
| [JsonConverter(typeof(JsonStringEnumConverter))] |
There was a problem hiding this comment.
I think we can remove the JsonConverter and make the CipherId nullable?
gbubemismith
dismissed stale reviews from rkac-bw and shane-melton
via
6f310ea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14381
📔 Objective
Admin endpoint to bulk create new tasks on the Access Intelligence page. Should accept a list of CipherIdsand the TaskType.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes