[BEEEP][PM-16921] Improve validation tax information when subscribing to pre…

[jonashendrickx]

…mium

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16921

📔 Objective

• Passes line 1, line 2, state, city to Stripe.

• Correctly requires both postal code and country when submitting the payment.

• Depends on: [PM-16921] Verify tax information is being passed correctly and valid… clients#12800

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 2.94118% with 33 lines in your changes missing coverage. Please review.

Project coverage is 44.32%. Comparing base (ce2ecf9) to head (cb0b705).
Report is 64 commits behind head on main.

Files with missing lines	Patch %	Lines
...e/Services/Implementations/StripePaymentService.cs	0.00%	23 Missing ⚠️
src/Api/Auth/Controllers/AccountsController.cs	0.00%	6 Missing ⚠️
...Api/Models/Request/Accounts/PremiumRequestModel.cs	20.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5247      +/-   ##
==========================================
+ Coverage   43.77%   44.32%   +0.54%     
==========================================
  Files        1483     1482       -1     
  Lines       68569    68376     -193     
  Branches     6212     6171      -41     
==========================================
+ Hits        30016    30307     +291     
+ Misses      37243    36761     -482     
+ Partials     1310     1308       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – c771fe41-abfd-48c0-b3a5-e41ada6bebbe

New Issues (6)

Checkmarx found the following issues in this Pull Request

Severity	Issue	Source File / Package	Checkmarx Insight
	CSRF	/src/Api/Tools/Controllers/SendsController.cs: 193	details Method PostFile at line 193 of /src/Api/Tools/Controllers/SendsController.cs gets a parameter from a user request from PostFile. This parameter val... Attack Vector
	Log_Forging	/src/Api/Auth/Controllers/AccountsController.cs: 639	details Method PostPremium at line 639 of /src/Api/Auth/Controllers/AccountsController.cs gets user input from element model. This element’s value flows th... Attack Vector
	Log_Forging	/src/Api/Auth/Controllers/AccountsController.cs: 639	details Method PostPremium at line 639 of /src/Api/Auth/Controllers/AccountsController.cs gets user input from element model. This element’s value flows th... Attack Vector
	Log_Forging	/src/Api/Auth/Controllers/AccountsController.cs: 639	details Method PostPremium at line 639 of /src/Api/Auth/Controllers/AccountsController.cs gets user input from element model. This element’s value flows th... Attack Vector
	Log_Forging	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 170	details Method Post at line 170 of /src/Api/AdminConsole/Controllers/OrganizationsController.cs gets user input from element model. This element’s value fl... Attack Vector
	Log_Forging	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 185	details Method CreateWithoutPaymentAsync at line 185 of /src/Api/AdminConsole/Controllers/OrganizationsController.cs gets user input from element model. Th... Attack Vector

Fixed Issues (9)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	CSRF	/src/Api/Tools/Controllers/OrganizationExportController.cs: 53
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 470
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 845
	Heap_Inspection	/src/Core/Constants.cs: 168
	Heap_Inspection	/src/Core/Constants.cs: 167
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/RecoveryController.cs: 38
	Use_Of_Hardcoded_Password	/src/Core/Constants.cs: 168
	Use_Of_Hardcoded_Password	/src/Core/Constants.cs: 167