-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust handling of GH action dependencies for CI/CD partnership #5274
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5274 +/- ##
=======================================
Coverage 44.02% 44.02%
=======================================
Files 1476 1476
Lines 68291 68291
Branches 6175 6175
=======================================
Hits 30065 30065
Misses 36919 36919
Partials 1307 1307 ☔ View full report in Codecov by Sentry. |
}, | ||
{ | ||
"groupName": "gh minor", | ||
"groupName": "github-action minor", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ This is "github action dependencies" on bitwarden/clients#12818.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like that github-action minor
is actually more descriptive and was going to raise a PR to update the description on clients, since I think this will be the title of the resulting PR (and thus the naming has implications to clarity in the future). Do you have a preference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this more, it just wasn't merged yet. Consistency would be great, and you could update the template
repo to match.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Will do!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the clients to match with bitwarden/clients#12896.
Great job, no security vulnerabilities found in this Pull Request |
🎟️ Tracking
bitwarden.atlassian.net/browse/PM-14640
📔 Objective
Analog to bitwarden/clients#12818 on the clients repo.
As we have started to share ownership of our build pipelines between BRE and Platform, BRE no longer owns all of the github-action-managed dependencies. The current renovate.json results in misleading PR titles like bitwarden/clients#12706.
This PR does the following:
dockerfile
anddocker-compose
managers as those are owned by BRE.❓ What will upcoming PRs look like?
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes