Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limit item deletion organization setting migration #5283

Merged
merged 7 commits into from
Jan 21, 2025

Conversation

JimmyVo16
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17136

📔 Objective

  1. Update source SQL files for the Organization table, along with stored procedures and views that reference it.
  2. Add stored procedure migrations for MS SQL.
  3. Add Entity Framework migrations for MySQL, SQLite, and PostgreSQL.

📸 Screenshots

MS SQL

image

MySQL

image

PostgreSQL

image

SQLite

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@JimmyVo16 JimmyVo16 requested review from a team as code owners January 17, 2025 15:42
@JimmyVo16 JimmyVo16 requested a review from r-tome January 17, 2025 15:42
@JimmyVo16 JimmyVo16 self-assigned this Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.07%. Comparing base (0de108e) to head (feb6fe3).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5283   +/-   ##
=======================================
  Coverage   44.07%   44.07%           
=======================================
  Files        1476     1476           
  Lines       68258    68259    +1     
  Branches     6178     6178           
=======================================
+ Hits        30087    30088    +1     
  Misses      36864    36864           
  Partials     1307     1307           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 17, 2025

Logo
Checkmarx One – Scan Summary & Detailsa385a355-07af-48a0-9899-62492c0754e3

Fixed Issues (10)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Tools/Controllers/OrganizationExportController.cs: 53
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 639
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 713
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 639
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 110
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 713
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 110
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 110
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 713
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 639

Copy link
Contributor

@r-tome r-tome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one detail that I think is not right

Copy link
Contributor

@r-tome r-tome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Copy link
Contributor

@rkac-bw rkac-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JimmyVo16 JimmyVo16 merged commit 4069ac3 into main Jan 21, 2025
58 checks passed
@JimmyVo16 JimmyVo16 deleted the ac/pm-17136/add-limit-item-deletion-migration branch January 21, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants