[PM-17353] feat: allow configuring GlobalSettings via KeyPerFile configuration provider #5303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, one can make use of Docker Compose Secrets.
🎟️ Tracking
https://community.bitwarden.com/t/add-support-for-docker-secrets-to-self-host-project/69705/3
📔 Objective
Since there was/is no vital conversion in the corresponding Discourse thread, I thought I give it a shot and propose my desired change as a PR. Please bear with me if this violates one of your processes - I'm happy to learn and adapt 🙂
As written in the corresponding thread, it would be great if one could make use of Docker Compose Secrets, especially for passing installation ID and key. Of course, following the common
_FILE
suffix convention would be the very best solution. But as a first step in this direction, I decided to add the Key-per-file configuration provider so that one can start a Docker stack like this:This way, .NET will automatically pick up all files within the config directory
/run/secrets
(which is the default of Docker Compose, see here) and map them convention-based to the corresponding config object.📸 Screenshots
Not applicable since there is no UI change.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes