[PM-12490] Extract OrganizationService.EnableAsync into commands

[r-tome]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12490

📔 Objective

Extract OrganizationService.EnableAsync to OrganizationEnableCommand.

Add unit tests for OrganizationEnableCommand.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.

Project coverage is 44.39%. Comparing base (669c253) to head (bf7871c).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
...ervices/Implementations/PaymentSucceededHandler.cs	0.00%	4 Missing ⚠️
...ices/Implementations/SubscriptionUpdatedHandler.cs	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5321      +/-   ##
==========================================
+ Coverage   44.37%   44.39%   +0.02%     
==========================================
  Files        1487     1489       +2     
  Lines       68595    68602       +7     
  Branches     6179     6179              
==========================================
+ Hits        30438    30459      +21     
+ Misses      36838    36824      -14     
  Partials     1319     1319              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – f68406ea-1603-42ec-a4bf-3215e8d8ce69

Great job, no security vulnerabilities found in this Pull Request

[amorask-bitwarden]

👍 from Billing

[r-tome]

I had to fix a few merge conflicts

[JimmyVo16]

Everything looks good, just one minor request with the test code.

[cturnbull-bitwarden]

🎉

[cturnbull-bitwarden]

Just leaving a non-blocking drive-by-nit ⛏️ before approving! Looking at these two methods, it feels like they can be combined into a single method. I don't have all the context around this, so there's probably a reason they're not! Something like this is what I was imagining:

public async Task EnableAsync(Guid organizationId, DateTime? expirationDate = null)
{
    var organization = await _organizationRepository.GetByIdAsync(organizationId);
    if (organization is null || organization.Enabled || expirationDate is not null && organization.Gateway is null)
    {
        return;
    }

    organization.Enabled = true;

    if (expirationDate is not null && organization.Gateway is not null)
    {
        organization.ExpirationDate = expirationDate;
        organization.RevisionDate = DateTime.UtcNow;
    }

    await _organizationRepository.ReplaceAsync(organization);
    await _applicationCacheService.UpsertOrganizationAbilityAsync(organization);
}

[r-tome]

Good thinking! I've pushed a commit with your suggestion. I also added an extra unit test just to make sure we're not breaking anything.