Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-17562] Initial POC of Distributed Events #5323
[PM-17562] Initial POC of Distributed Events #5323
Changes from 10 commits
d386eee
21fe94c
8f2a013
ee19ff5
2c9079b
1e5690c
7f8f1a9
e238bf9
58b5c32
ab68e43
289daf6
5cc8483
e567e18
2b3dca4
3ca63f9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 14 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventHttpPostListener.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventHttpPostListener.cs#L14
Check warning on line 27 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventHttpPostListener.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventHttpPostListener.cs#L22-L27
Check warning on line 35 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventHttpPostListener.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventHttpPostListener.cs#L30-L35
Check warning on line 33 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventListenerBase.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventListenerBase.cs#L21-L33
Check warning on line 38 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventListenerBase.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventListenerBase.cs#L36-L38
Check warning on line 52 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventListenerBase.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventListenerBase.cs#L40-L52
Check warning on line 68 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventListenerBase.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventListenerBase.cs#L55-L68
Check warning on line 70 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventListenerBase.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventListenerBase.cs#L70
Check warning on line 76 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventListenerBase.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventListenerBase.cs#L73-L76
Check warning on line 83 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventListenerBase.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventListenerBase.cs#L79-L83
Check warning on line 90 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventListenerBase.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventListenerBase.cs#L86-L90
Check warning on line 13 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventRepositoryListener.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventRepositoryListener.cs#L13
Check warning on line 23 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventRepositoryListener.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventRepositoryListener.cs#L19-L23
Check warning on line 28 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventRepositoryListener.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventRepositoryListener.cs#L26-L28
Check warning on line 21 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventWriteService.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventWriteService.cs#L13-L21
Check warning on line 24 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventWriteService.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventWriteService.cs#L23-L24
Check warning on line 29 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventWriteService.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventWriteService.cs#L27-L29
Check warning on line 31 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventWriteService.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventWriteService.cs#L31
Check warning on line 33 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventWriteService.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventWriteService.cs#L33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
โ Is JSON our best option for serialization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, at least to start. Were you thinking about something like Protobuf?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps ... just don't know best practices with Rabbit.
Check warning on line 36 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventWriteService.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventWriteService.cs#L35-L36
Check warning on line 42 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventWriteService.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventWriteService.cs#L39-L42
Check warning on line 46 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventWriteService.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventWriteService.cs#L45-L46
Check warning on line 50 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventWriteService.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventWriteService.cs#L48-L50
Check warning on line 55 in src/Core/AdminConsole/Services/Implementations/RabbitMqEventWriteService.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/RabbitMqEventWriteService.cs#L53-L55
Check warning on line 277 in src/Core/Settings/GlobalSettings.cs
Codecov / codecov/patch
src/Core/Settings/GlobalSettings.cs#L277
Check warning on line 282 in src/Core/Settings/GlobalSettings.cs
Codecov / codecov/patch
src/Core/Settings/GlobalSettings.cs#L282
Check warning on line 287 in src/Core/Settings/GlobalSettings.cs
Codecov / codecov/patch
src/Core/Settings/GlobalSettings.cs#L287
Check warning on line 292 in src/Core/Settings/GlobalSettings.cs
Codecov / codecov/patch
src/Core/Settings/GlobalSettings.cs#L292
Check warning on line 92 in src/Events/Startup.cs
Codecov / codecov/patch
src/Events/Startup.cs#L88-L92
Check warning on line 99 in src/Events/Startup.cs
Codecov / codecov/patch
src/Events/Startup.cs#L95-L99
Check warning on line 334 in src/SharedWeb/Utilities/ServiceCollectionExtensions.cs
Codecov / codecov/patch
src/SharedWeb/Utilities/ServiceCollectionExtensions.cs#L329-L334
Check warning on line 338 in src/SharedWeb/Utilities/ServiceCollectionExtensions.cs
Codecov / codecov/patch
src/SharedWeb/Utilities/ServiceCollectionExtensions.cs#L336-L338