Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17730] Don't enable tax for customer without tax info #5347

Merged

Conversation

amorask-bitwarden
Copy link
Contributor

🎟️ Tracking

📔 Objective

https://bitwarden.atlassian.net/browse/PM-17730

After the Stripe Sources API Deprecation flag was removed, trial initiation started using the OrganizationBillingService, which was always trying to enable automatic tax even for cases where the Customer had no tax info (like in a trial initiation).

📸 Screenshots

Screen.Recording.2025-01-30.at.8.40.20.AM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@amorask-bitwarden amorask-bitwarden requested a review from a team as a code owner January 30, 2025 13:43
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 44.31%. Comparing base (2f2ef20) to head (b6e1cfa).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ices/Implementations/OrganizationBillingService.cs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5347      +/-   ##
==========================================
- Coverage   44.32%   44.31%   -0.01%     
==========================================
  Files        1483     1483              
  Lines       68419    68427       +8     
  Branches     6173     6174       +1     
==========================================
  Hits        30326    30326              
- Misses      36784    36792       +8     
  Partials     1309     1309              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details2a46ec87-434e-42e5-ad23-1ee108f05e4b

Great job, no security vulnerabilities found in this Pull Request

@amorask-bitwarden amorask-bitwarden merged commit ad2ea4c into main Jan 30, 2025
53 checks passed
@amorask-bitwarden amorask-bitwarden deleted the billing/PM-17730/trial-initiation-subscription-failure branch January 30, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants