[PM-15637] Notify Custom Users with “Manage Account Recovery” permission for Device Approval Requests #5359
+131
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ManageResetPassword permission
…d validate notification email recipients
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5359 +/- ##
==========================================
- Coverage 44.22% 44.22% -0.01%
==========================================
Files 1492 1492
Lines 68869 68911 +42
Branches 6203 6203
==========================================
+ Hits 30460 30475 +15
- Misses 37089 37116 +27
Partials 1320 1320 ☔ View full report in Codecov by Sentry. |
|
New Issues (4)Checkmarx found the following issues in this Pull Request
Fixed Issues (7)Great job! The following issues were fixed in this Pull Request
|
JimmyVo16
reviewed
Feb 3, 2025
| @@ -297,10 +297,34 @@ private async Task NotifyAdminsOfDeviceApprovalRequestAsync(OrganizationUser org | |||
| return; | |||
| } | |||
|
|
|||
| var admins = await _organizationUserRepository.GetManyByMinimumRoleAsync( | |||
| var adminEmails = await GetAdminAndAccountRecoveryEmailsAsync(organizationUser.OrganizationId); | |||
There was a problem hiding this comment.
None-blocking question: I guess it's safe to say that adminEmails will never be empty because an organization will have at least one owner?
There was a problem hiding this comment.
Yes, exactly! We always check if an organization has at least one confirmed owner when updating/removing a user.
JimmyVo16
approved these changes
Feb 3, 2025
Patrick-Pimentel-Bitwarden
approved these changes
Feb 3, 2025
…mail-notification-for-device-approval-requests
|
r-tome
deleted the
ac/pm-15637/custom-manage-account-recovery-email-notification-for-device-approval-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15637
📔 Objective
While testing #5270 it was noticed that notifications were missing for Custom Users with “Manage Account Recovery” permission
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes