Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch ownership to architecture #139

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Switch ownership to architecture #139

merged 1 commit into from
Jan 21, 2025

Conversation

withinfocus
Copy link
Contributor

🎟️ Tracking

From chat.

📔 Objective

While I think general ownership of the template is amongst tech leadership, the architecture group is largely driving direction here and can be a more focused codeowner.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@withinfocus withinfocus marked this pull request as ready for review January 21, 2025 13:30
@withinfocus withinfocus requested a review from a team as a code owner January 21, 2025 13:30
Copy link

Logo
Checkmarx One – Scan Summary & Details3eb8383a-4aa7-4ff2-a09f-d53f9fab4609

Great job, no security vulnerabilities found in this Pull Request

@willmartian
Copy link

Seems fine to me--let me check to see if there any tech leads who oppose this.

Copy link

@willmartian willmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@withinfocus withinfocus merged commit a683f03 into main Jan 21, 2025
5 checks passed
@withinfocus withinfocus deleted the newowner branch January 21, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants