Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model validations for phone_numbers #3114

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

phil-l-brockwell
Copy link
Contributor

@phil-l-brockwell phil-l-brockwell commented Oct 21, 2024

📝 A short description of the changes

  • Uses the phonelib gem to add validations for phone numbers to the User model

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

  • The attached rake task should be run as soon as this is deployed: bundle exec rake db:remove_invalid_user_phone_numbers. It will fix invalidated User records by removing the invalid phone_numbers.

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

image
image
image

@phil-l-brockwell phil-l-brockwell force-pushed the pb/add-phone-number-validations branch 5 times, most recently from 2e1d9dd to 7facc1a Compare October 22, 2024 12:51
@phil-l-brockwell phil-l-brockwell force-pushed the pb/add-phone-number-validations branch 6 times, most recently from 49d9312 to 79636b3 Compare November 6, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants