Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] SQL drivers are not relocated #153

Closed
bivashy opened this issue Feb 8, 2024 · 1 comment
Closed

[Bug] SQL drivers are not relocated #153

bivashy opened this issue Feb 8, 2024 · 1 comment
Labels
status: needs testing Issue or PR should be tested type: bug Something isn't working

Comments

@bivashy
Copy link
Owner

bivashy commented Feb 8, 2024

Describe the bug
MC-Auth relocates most of the libraries, but doesn't relocate SQL drivers. Driver classes should be relocated, else loaded by using IsolatedClassLoader.

To Reproduce
Steps to reproduce the behaviour:

  1. Install MC-Auth and LibertyBans, for example
  2. Configure both plugin to use same SQL driver
  3. See exception

Expected behavior
MC-Auth should load/relocate SQL drivers instead of directly binding to the BungeeCord/Velocity classpath.

Screenshots
_

Additional context
_
@bivashy bivashy added type: bug Something isn't working status: needs testing Issue or PR should be tested labels Feb 8, 2024
@bivashy bivashy mentioned this issue Feb 25, 2024
Merged
4 tasks
@bivashy
Copy link
Owner Author

bivashy commented Jun 28, 2024

#159

@bivashy bivashy closed this as completed Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: needs testing Issue or PR should be tested type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

fix/sql-drivers-are-not-relocated bivashy/MC-Auth-with-Link
1 participant
@bivashy