Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load SQL Drivers using isolated ClassLoader #159

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

bivashy
Copy link
Owner

@bivashy bivashy commented Feb 25, 2024

Pull Request Etiquette

  • I have checked the PRs for upcoming features/bug fixes.

Changes

  • Internal code
  • API (affecting end-user code)
  • Other: _____

Closes Issue: #153

Description

This Pull Request loads DatabaseHelper and JDBC driver using custom ClassLoader instead of loading directly into AuthPlugin class loader.
Current state: Done

@bivashy bivashy added the status: needs testing Issue or PR should be tested label Mar 16, 2024
@bivashy bivashy changed the title [WIP] Load SQL Drivers using isolated ClassLoader Load SQL Drivers using isolated ClassLoader Mar 16, 2024
@bivashy bivashy marked this pull request as ready for review March 16, 2024 16:58
@bivashy
Copy link
Owner Author

bivashy commented Apr 3, 2024

Plugin now uses ServiceLoader#load(Class<T>, ClassLoader) and loading into the IsolatedClassLoader instead of plugin ClassLoader.
Other plugins cannot have access to the database driver directly, and it doesn't interfere if they are properly relocating, or else loading isolated.

@bivashy bivashy merged commit 5d4f33d into main Apr 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs testing Issue or PR should be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant