Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace LinkUserTemplate in api module #112

Merged
merged 3 commits into from
Nov 4, 2023
Merged

Replace LinkUserTemplate in api module #112

merged 3 commits into from
Nov 4, 2023

Conversation

bivashy
Copy link
Owner

@bivashy bivashy commented Nov 4, 2023 •
edited
Loading

Pull Request Etiquette

  • I have checked the PRs for upcoming features/bug fixes.

Changes

  • Internal code
  • API (affecting end-user code)
  • Other: _____

Closes Issue: NaN

Description

For some reason there are two classes LinkUserTemplate in core and api. And usage of LinkUserTemplate in api not important at all, and can be easily replaced. Summarizing all, this pull request simply replaces LinkUserTemplate in api module.

@bivashy bivashy added the status: needs testing Issue or PR should be tested label Nov 4, 2023
@bivashy bivashy changed the title Replace LinkUserTemplate#of with LinkUser#of Replace LinkUserTemplate in api module Nov 4, 2023
@bivashy bivashy removed the status: needs testing Issue or PR should be tested label Nov 4, 2023
@bivashy bivashy marked this pull request as ready for review November 4, 2023 19:23
@bivashy bivashy merged commit f52bc7b into main Nov 4, 2023
3 checks passed
@bivashy bivashy deleted the refactor/remove-link-user-tempalate-api branch November 22, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bivashy