Implements feature to type password in chat to login/regi…

[scaik]

No description provided.

[bivashy]

Hello there! Thanks for your first pull request!
Everything seems to be okay. I also like the way you've implemented it

I'll squash and merge (after testing) and attach your profile link in the GitHub and Spigot releases.

But first of all, please check the review.

[bivashy]

Everything seems to be okay, I'll try to test this as soon as possible.

After testing I'll approve that PR.

[bivashy]

I've tested, it is great! Thank you for the implementation of this future.

But there are several problems with register implementation:

• Player could accidentially register password with whiteline characters, for example if player would type into chat: 'password password', plugin will consider that as 'test test' password instead of 'test'
• Password confirmation requirement such like in /register <pass_repeat> doesn't work on chat too.

Solution:
Simply split by whitespace before calling PasswordChatEvent

Pull Request that fixes it:
https://github.com/scaik123/MC-Auth-with-Link/pull/1

You could deny Pull Request if you have more elegant solution

[scaik]

yeah, that's seems to be a good solution, but i found a probable bug. idk was it intended to be like that, so please, check out the review

[scaik]

or we could require player to chat the password two times(type password, press enter, type conf password, press enter) and throw an error if the password contains whitespace

[bivashy]

yeah, that's seems to be a good solution, but i found a probable bug. idk was it intended to be like that, so please, check out the review

Sorry, but i can't see your review if you meant that

or we could require player to chat the password two times(type password, press enter, type conf password, press enter) and throw an error if the password contains whitespace

Nice solution, but most importantly it should be intuitive for user to use.

[scaik]