-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Determine shader output type #3098
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should come up with solution that works with all shader backends.
could you elaborate on what you'd expect? are you referring to ensuring it compiles and outputs in every backend or that this is too gl/vulkan specific? i've tested it with hlsl, spirv, gl and gles - seems to compile atleast. Was intending to create an example once the "how" was decided |
I would suggest creating example first... This hack is sufficient to create example. Example will let you test that everything works everywhere as expected. This will allow you to explore all issues with all backends without worrying to much how it will look at the end. Then afterwards we can come up with solution which will most likely present itself once you solve those issues you discovered. Also keep in mind that |
34e2c28
to
9982b4b
Compare
Signed-off-by: Sam Hellawell <[email protected]>
9982b4b
to
64b10e5
Compare
Signed-off-by: Sam Hellawell <[email protected]>
64b10e5
to
7e94a9f
Compare
…haderc-output-type
EG:
Perhaps not the best way of doing it - happy to implement suggestions