Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable debug information for Vulkan shaders #3193

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

Arcnor
Copy link
Contributor

@Arcnor Arcnor commented Nov 6, 2023

No description provided.

Copy link
Owner

@bkaradzic bkaradzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add this for Metal too.

@Arcnor
Copy link
Contributor Author

Arcnor commented Nov 6, 2023

You should add this for Metal too.

Sure, but I don't have access to a Mac for a while, so I won't be able to test it...

@bkaradzic
Copy link
Owner

Sure, but I don't have access to a Mac for a while, so I won't be able to test it...

That's fine, there is CI. And it's the identical glslang::SpvOptions options; code in shaderc_metal.cpp, just apply the same change.

@Arcnor
Copy link
Contributor Author

Arcnor commented Nov 6, 2023

Sure, but I don't have access to a Mac for a while, so I won't be able to test it...

That's fine, there is CI. And it's the identical glslang::SpvOptions options; code in shaderc_metal.cpp, just apply the same change.

I didn't realize it was using SPIRV as well. Done.

@bkaradzic bkaradzic merged commit b01c5d5 into bkaradzic:master Nov 6, 2023
13 checks passed
jay3d pushed a commit to jay3d/bgfx that referenced this pull request Dec 7, 2023
* Enable debug information for Vulkan shaders

* Enable debug information for Metal shaders
mipek pushed a commit to mipek/bgfx that referenced this pull request Mar 2, 2024
* Enable debug information for Vulkan shaders

* Enable debug information for Metal shaders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants