Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of bx::bit_cast #3212

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Make use of bx::bit_cast #3212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions examples/09-hdr/hdr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,9 +362,10 @@ class ExampleHDR : public entry::AppI

if (bgfx::isValid(m_rb) )
{
union { uint32_t color; uint8_t bgra[4]; } cast = { m_lumBgra8 };
float exponent = cast.bgra[3]/255.0f * 255.0f - 128.0f;
float lumAvg = cast.bgra[2]/255.0f * bx::exp2(exponent);
struct Packed { uint8_t bgra[4]; } arr = bx::bit_cast<Packed>(m_lumBgra8);
float exponent = arr.bgra[3] / 255.0f * 255.0f - 128.0f;
float lumAvg = arr.bgra[2] / 255.0f * bx::exp2(exponent);

ImGui::SliderFloat("Lum Avg", &lumAvg, 0.0f, 1.0f);
}

Expand Down
28 changes: 7 additions & 21 deletions examples/33-pom/pom.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,29 +37,15 @@ struct PosTangentBitangentTexcoordVertex

bgfx::VertexLayout PosTangentBitangentTexcoordVertex::ms_layout;

uint32_t packUint32(uint8_t _x, uint8_t _y, uint8_t _z, uint8_t _w)
{
union
{
uint32_t ui32;
uint8_t arr[4];
} un;

un.arr[0] = _x;
un.arr[1] = _y;
un.arr[2] = _z;
un.arr[3] = _w;

return un.ui32;
}

uint32_t packF4u(float _x, float _y = 0.0f, float _z = 0.0f, float _w = 0.0f)
{
const uint8_t xx = uint8_t(_x*127.0f + 128.0f);
const uint8_t yy = uint8_t(_y*127.0f + 128.0f);
const uint8_t zz = uint8_t(_z*127.0f + 128.0f);
const uint8_t ww = uint8_t(_w*127.0f + 128.0f);
return packUint32(xx, yy, zz, ww);
struct Packed { uint8_t value[4]; } arr = { 0 };
arr.value[0] = uint8_t(_x * 127.0f + 128.0f);
arr.value[1] = uint8_t(_y * 127.0f + 128.0f);
arr.value[2] = uint8_t(_z * 127.0f + 128.0f);
arr.value[3] = uint8_t(_w * 127.0f + 128.0f);

return bx::bit_cast<uint32_t>(arr);
}

static PosTangentBitangentTexcoordVertex s_cubeVertices[24] =
Expand Down
7 changes: 0 additions & 7 deletions src/bgfx_p.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,13 +605,6 @@ namespace bgfx
release( (const Memory*)_mem);
}

inline uint32_t castfu(float _value)
{
union { float fl; uint32_t ui; } un;
un.fl = _value;
return un.ui;
}

inline uint64_t packStencil(uint32_t _fstencil, uint32_t _bstencil)
{
return (uint64_t(_bstencil)<<32)|uint64_t(_fstencil);
Expand Down
3 changes: 1 addition & 2 deletions src/shader_dxbc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1723,11 +1723,10 @@ namespace bgfx
case DxbcOperandType::Imm64:
for (uint32_t jj = 0; jj < operand.num; ++jj)
{
union { uint32_t i; float f; } cast = { operand.un.imm32[jj] };
size += bx::snprintf(&_out[size], bx::uint32_imax(0, _size-size)
, "%s%f"
, 0 == jj ? "(" : ", "
, cast.f
, bx::bit_cast<float>(operand.un.imm32[jj])
);
}

Expand Down
Loading