Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/61 pwa #135

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Feature/61 pwa #135

merged 2 commits into from
Dec 4, 2023

Conversation

caebr
Copy link
Collaborator

@caebr caebr commented Nov 13, 2023

Umsetzung von #61 mit https://vite-pwa-org.netlify.app/

Ich habe im Rahmen dieser Story auch gleich #69 umgesetzt.

@caebr caebr requested a review from hupf November 13, 2023 10:04
@caebr caebr self-assigned this Nov 13, 2023
@caebr
Copy link
Collaborator Author

caebr commented Nov 13, 2023

@hupf Es gibt scheinbar noch ein Problem mit dem PWA-Plugin bzw. den Service Workern und den Cypress Tests. Das muss ich mir noch anschauen.

@hupf
Copy link
Collaborator

hupf commented Dec 4, 2023

  • Die Offline-Seite funktioniert soweit – getestet im Chrome (im Network Panel auf Offline setzen) und im Firefox (File → Work Offline).
  • Habe den Service Worker im Development Modus deaktiviert um ungewünschtes Caching zu verhindern.
  • Die Cypress Tests laufen lokal durch.

@hupf hupf force-pushed the feature/61-pwa branch 2 times, most recently from 14b17b4 to e6449e3 Compare December 4, 2023 09:57
vite.config.ts Outdated
VitePWA({
registerType: "autoUpdate",
devOptions: {
enabled: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Würde das wohl per Default mal deaktivieren, weil es zu ungewünschten Effekten kommen könnte (ev. auch in den Tests). Vielleicht mit einem Kommentar, damit man weiss wie man es lokal testen kann, wenn man möchte.

@hupf hupf merged commit a6ba380 into main Dec 4, 2023
2 checks passed
@hupf hupf deleted the feature/61-pwa branch December 4, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants