Fix macos build #121
Fix macos build #121
Conversation
|
Thanks, we were stuck on this one and didn't know how to fix it. Also see #116 |
|
In ragrds to the failing mingw build, for some reason mirrorbrain picks a mirror that doesn't provide repos in the home: namespace. Maybe it's tagged incorrectly, I'll ask the oS heros later. |
|
maybe we can add a guard 😭 #if defined(__linux__) || defined(_WIN32)
// do nothing
#else
#include <clocale>
#endif
|
|
no, why would we? it seems to work on linux at least. The buils failures aren't due to your commit. (or doesn't it work on windows?) |
sorry, I misunderstood what you said. |
|
can this PR be merged? |
|
I've asked about it, since I want this merged too. Development is quite slow, unless something affects @blackhole89 himself :)
|
|
Argh, sorry! I'm merging it for now, but both the MinGW and the Darwin CI build seem to fail with something pertaining to clatexmath. |
use openmath branch |
no, that wasn't the issue. Darwin CI was failing with linuxbrew and incorrect libstdc++, #124 fixes that. newer OS X versions seem to fail with cLaTeXMath however (according to one iMac NoteKit user in the chatroom), so I have set up sp1ritCS/tap/notekit-sp1rit and sp1ritCS/tap/microtex that use MicroTeX/openmath. However (likely due to homebrew wierdness) notekit-sp1rit seems to fail to install the datadir and charter fonts property (maybe only when installing the bottle), but I haven't looked further into that. |
see #120