Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mainwindow: gated gdk_wayland_* calls behind version check #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sp1ritCS
Copy link
Contributor

@sp1ritCS sp1ritCS commented May 3, 2023

This should ensure that NoteKit will continue to be build on RHEL 8, as this currently fails with:

[   99s] ../mainwindow.cpp: In member function ‘void CMainWindow::SettingCsdUpdate()’:
[   99s] ../mainwindow.cpp:801:5: error: ‘gdk_wayland_window_announce_ssd’ was not declared in this scope
[   99s]      gdk_wayland_window_announce_ssd(window);
[   99s]      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[   99s] ../mainwindow.cpp:801:5: note: suggested alternative: ‘gdk_wayland_window_announce_csd’
[   99s]      gdk_wayland_window_announce_ssd(window);
[   99s]      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[   99s]      gdk_wayland_window_announce_csd

@sp1ritCS sp1ritCS changed the title mainwindow: gated of gdk_wayland_* calles behind version check mainwindow: gated of gdk_wayland_* calls behind version check May 3, 2023
@sp1ritCS sp1ritCS changed the title mainwindow: gated of gdk_wayland_* calls behind version check mainwindow: gated gdk_wayland_* calls behind version check May 3, 2023
This should ensure that NoteKit will continue to be build on RHEL 8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant