-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving NoteKit closer to similar "GNOME" applications #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch from Gtk::Menu to Gio::Menu (gh blackhole89#84) - Added "About" Dialog - Added Adwaita screenshots from @LyesSaadi
- version will be resolved from meson prj version - changed title of @blackhole89 - added clatexmath wrap fallback
- replaced tempnam with mkstemp (will have to be fixed on misrosoft later)
this allows for a dynamic amount of color buttons within the toolbar Additionally: - Fixed issue regarding de-/ serialization of drawings that occured due to the change from float to double for the RGBA values of a stroke. - Fixed issue with the navigation pane selecting the first instead of the active document. - Replaced "^ " with "^\t" - Maybe fixed compilation issues on Darwin (less likely MinGW too)
…button got updated
…ange can be handled
- Disabling CSD on X11 now renders SSD - Fixed CSD setting being set to true after restart
- Support for Wayland SSD (KDE Plasma, wlroots) - Added notes about certain features and issues - Fixed issue where NoteKit always starts with CSD disabled
Closed as it has been merged into master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, here it is 😄 .
Additions:
source devel/bin/activate
)Changes:
tempnam
withmkstemp
to prevent the linker warningsBugfixes:
gtk_file_chooser_get_current_folder
was incorrect, as the current folder is not necessarily the same as the selected folder, leading to issues where the FileChooserButton showed the correct folder, but NoteKit was used a different one)New Bugs:
If you actually end up merging this, consider doing it in a way that preserves the commit history of the gnome branch, as it might be of value (also each commit will build on [my] linux :D).
[0]: I don't think the benefits outweigh the downsides.
- for some reason when running notekit via X11 it refuses to show the app menubar
- also on x11 the appmenu button only becomes visible after maximizing the window (going back to normal size doesn't hide the button again)
- the global app menu button behaves wierdly (could be fixed with custom css, however not a good idea as it it likely to break themes)
- some themes (flat-remix-gtk) like to hijack the menu button (by setting the opacity to 0) and then render their own icon on top of it.
[1]: https://github.com/sp1ritCS/notekit/blob/d21e7a053a0ac124d8874e753d35d2ed8d7394f9/mainwindow.cpp#L601