Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving NoteKit closer to similar "GNOME" applications #99

Closed
wants to merge 28 commits into from

Conversation

sp1ritCS
Copy link
Contributor

@sp1ritCS sp1ritCS commented May 26, 2021

Well, here it is 😄 .

Additions:

  • "Zen"/hide user-interface mode (finding a better name is up to you.)
  • @LyesSaadi's Adwaita Screenshots from Flatpak: add manifest #60
  • About dialog
  • devel environment script (inspired by python's venv) that sets a development env up for you (source devel/bin/activate)
  • Added a few notes that may help solve a few issues down the line

Changes:

  • replaced Gtk::Menu with Gio::Menu and Actions, however not as a global menu [0].
  • Droped jsoncpp in favour of gsettings
    • keep in mind that gsettings != dconf, but rather a pluggable configuration library
    • revised preferences dialog
    • changed stroke color floats to doubles
    • changes are now directly impacting what they are supposed to change (except Syntax Highlighting and to a limited extend CSD [1])
    • added small shell script that migrates json config to gsettings
    • added postinstall script that regenerates schema/icon cache & desktop db (could be replaced by gnome.postinstall() on meson >= 0.57)
  • replaced tempnam with mkstemp to prevent the linker warnings
  • added clatexmath wrap that meson can fall back to if clatexmath is not installed
  • added build instructions with meson

Bugfixes:

  • Selecting a color in Gtk's color picker now updates the current pen color of the sourceview too (before that pen continued to draw with the old color, until you press it's button [whose color got updated 🙃] again)
  • The use of gtk_file_chooser_get_current_folder was incorrect, as the current folder is not necessarily the same as the selected folder, leading to issues where the FileChooserButton showed the correct folder, but NoteKit was used a different one)

New Bugs:

  • dunno, you'll likely find something if you want too (e.g. changing settings within dconf/win registry while NoteKit is running that are then live-updated by gsettings sounds like a good idea 🤣 )
  • At least Wayfire does not honor repeated calls of setting CSD/SSD, thus toggling csd requires a restart or you'll either have no headerbar and no ssd or you'll have both (quite bugged, as the border begin at the start of the window shadow).
  • Turning off CSD on OSX and w32 leads to the window having no decorations at all. (gtk+3 doesn't support this, you'd need to move to gtk4. See code comments for more info)

If you actually end up merging this, consider doing it in a way that preserves the commit history of the gnome branch, as it might be of value (also each commit will build on [my] linux :D).

[0]: I don't think the benefits outweigh the downsides.
- for some reason when running notekit via X11 it refuses to show the app menubar
- also on x11 the appmenu button only becomes visible after maximizing the window (going back to normal size doesn't hide the button again)
- the global app menu button behaves wierdly (could be fixed with custom css, however not a good idea as it it likely to break themes)
- some themes (flat-remix-gtk) like to hijack the menu button (by setting the opacity to 0) and then render their own icon on top of it.
[1]: https://github.com/sp1ritCS/notekit/blob/d21e7a053a0ac124d8874e753d35d2ed8d7394f9/mainwindow.cpp#L601

sp1ritCS and others added 28 commits May 16, 2021 23:45
- Switch from Gtk::Menu to Gio::Menu (gh blackhole89#84)
- Added "About" Dialog
- Added Adwaita screenshots from @LyesSaadi
- version will be resolved from meson prj version
- changed title of @blackhole89
- added clatexmath wrap fallback
- replaced tempnam with mkstemp (will have to be fixed on misrosoft later)
this allows for a dynamic amount of color buttons within the toolbar
Additionally:
- Fixed issue regarding de-/ serialization of drawings that occured due to the change from float to double for the RGBA values of a stroke.
- Fixed issue with the navigation pane selecting the first instead of the active document.
- Replaced "^    " with "^\t"
- Maybe fixed compilation issues on Darwin (less likely MinGW too)
- Disabling CSD on X11 now renders SSD
- Fixed CSD setting being set to true after restart
- Support for Wayland SSD (KDE Plasma, wlroots)
- Added notes about certain features and issues
- Fixed issue where NoteKit always starts with CSD disabled
@sp1ritCS
Copy link
Contributor Author

guess I ran out of space in the first one

should close #84
replaces part of #59
partly contributes to #96

@sp1ritCS
Copy link
Contributor Author

Closed as it has been merged into master

@sp1ritCS sp1ritCS closed this Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant