Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial posteriors SMC and refactor to decouple tempering from SMC construction #729

Merged
merged 33 commits into from
Oct 5, 2024
Merged

Partial posteriors SMC and refactor to decouple tempering from SMC construction #729

merged 33 commits into from
Oct 5, 2024

Conversation

ciguaran
Copy link
Contributor

@ciguaran ciguaran commented Aug 27, 2024 •
edited
Loading

ciguaran and others added 27 commits July 29, 2024 11:07
@ciguaran
extracting taking last
4e9880a
@ciguaran
test passing
753b89b
@ciguaran
layering
46676e2
@ciguaran
example
1c26405
@ciguaran
more
6929d55
@ciguaran
Adding another example
e46e86c
@ciguaran
tests in place
f0ce4ba
@ciguaran
rolling back changes
3576690
@ciguaran
Adding test for num_mcmc_steps
5c34177
@ciguaran
format
8145cbb
@ciguaran
better test coverage
9550d5d
@ciguaran
Merge branch 'main' into ciguaran_waste_free_smc
02dccbe
@ciguaran
linter
c06b6ab
@ciguaran
Merge branch 'ciguaran_waste_free_smc' of github.com:ciguaran/blackja…
3eb18cb 
…x into ciguaran_waste_free_smc
@ciguaran
Flake8
424599e
@ciguaran
black
110b62e
@ciguaran
implementation[
964ec95
@ciguaran
partial posteriors implementation
93205f3
@ciguaran
rolling back some changes
c608b60
@ciguaran
linter
359be77
@ciguaran
fixing test
cef4ef0
@ciguaran
adding reference
0942087
@ciguaran
Merge branch 'main' into ciguaran_split_tempered_from_mcmc_construction
a9a4d0c
@ciguaran
typo
1304f9f
@ciguaran
exposing in top level api
aec2e51
@ciguaran
reruning precommit
cededec
@ciguaran
adding more steps
14919f2
@junpenglao junpenglao self-assigned this Sep 12, 2024
@junpenglao junpenglao self-requested a review October 1, 2024 04:41
junpenglao
junpenglao reviewed Oct 3, 2024
View reviewed changes
Copy link
Member

@junpenglao junpenglao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, I have a minor question on partial_logposterior_factory and selector.

Also, could you go through the doc string and make sure the formatting is consistent? There is some spacing issue (some of which I highlighted.

blackjax/smc/from_mcmc.py Outdated Show resolved Hide resolved
blackjax/smc/partial_posteriors_path.py Outdated Show resolved Hide resolved
blackjax/smc/partial_posteriors_path.py Outdated Show resolved Hide resolved
@ciguaran
Copy link
Contributor Author

ciguaran commented Oct 4, 2024

@junpenglao covered the comments. For some reason the benchmark is failing for HMC (code which is untouched by this PR) 🤔

@junpenglao junpenglao merged commit 5a25352 into blackjax-devs:main Oct 5, 2024
4 of 5 checks passed
@junpenglao
Copy link
Member

Yeah i think it is just some flakyness - merging. Thanks a lot!

aphc14 added a commit to aphc14/blackjax that referenced this pull request Oct 19, 2024
@aphc14
Partial posteriors SMC and refactor to decouple tempering from SMC co…
1dddd47 
…nstruction (blackjax-devs#729)

* extracting taking last

* test passing

* layering

* example

* more

* Adding another example

* tests in place

* rolling back changes

* Adding test for num_mcmc_steps

* format

* better test coverage

* linter

* Flake8

* black

* implementation[

* partial posteriors implementation

* rolling back some changes

* linter

* fixing test

* adding reference

* typo

* exposing in top level api

* reruning precommit

* adding more steps

* smaller step size

* fixes on comments

* small fix on formating

* renaming to data mask

* linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junpenglao junpenglao junpenglao approved these changes

Assignees

@junpenglao junpenglao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ciguaran @junpenglao