Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: MSPM0 cleanup #2004

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Fix: MSPM0 cleanup #2004

merged 2 commits into from
Nov 22, 2024

Conversation

dragonmux
Copy link
Member

Detailed description

This PR does some post-initial-PR cleanup for clang-tidy lints and small pattern issues that do not change functionality of the implementation but do improve code size and consistency a little. Nothing too huge - the implementation could still do with having the mass erase function refactored into a bank erase function and registered as flash->mass_erase rather than target->mass_erase, but without a part to test that against we're unwilling to go changing that for the moment.

Your checklist for this pull request

Closing issues

@dragonmux dragonmux added the Enhancement General project improvement label Nov 18, 2024
@dragonmux dragonmux added this to the v2.0 release milestone Nov 18, 2024
@dragonmux dragonmux requested a review from esden November 18, 2024 18:06
Copy link
Member

@esden esden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esden esden merged commit 729b773 into main Nov 22, 2024
36 checks passed
@dragonmux dragonmux deleted the fix/mspm0-cleanup branch November 22, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement General project improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants