Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
This PR does some post-initial-PR cleanup for clang-tidy lints and small pattern issues that do not change functionality of the implementation but do improve code size and consistency a little. Nothing too huge - the implementation could still do with having the mass erase function refactored into a bank erase function and registered as
flash->mass_erase
rather thantarget->mass_erase
, but without a part to test that against we're unwilling to go changing that for the moment.Your checklist for this pull request
Closing issues