Switch to LexicographicalComparator

blaginin · Jan 29, 2025 · 579ef2c · 579ef2c
1 parent 09a0844
commit 579ef2c
Show file tree

Hide file tree

Showing 2 changed files with 187 additions and 303 deletions.
diff --git a/datafusion/core/benches/aggregate_query_sql.rs b/datafusion/core/benches/aggregate_query_sql.rs
@@ -173,6 +173,35 @@ fn criterion_benchmark(c: &mut Criterion) {
             )
         })
     });
+
+    c.bench_function("first_many_columns", |b| {
+        b.iter(|| {
+            query(
+                ctx.clone(),
+                "SELECT first_value(u64_wide order by f64, u64_narrow, utf8) \
+                 FROM t group by u64_narrow",
+            )
+        })
+    });
+
+    c.bench_function("first_ignore_nulls", |b| {
+        b.iter(|| {
+            query(
+                ctx.clone(),
+                "SELECT first_value(u64_wide ignore nulls order by f64, u64_narrow, utf8) \
+                 FROM t group by u64_narrow",
+            )
+        })
+    });
+
+    c.bench_function("first_one_column", |b| {
+        b.iter(|| {
+            query(
+                ctx.clone(),
+                "SELECT first_value(u64_wide order by f64) FROM t group by u64_narrow",
+            )
+        })
+    });
 }
 
 criterion_group!(benches, criterion_benchmark);