Uncomment the shared tests in string_query.slt.part and removed tests…

… copies everywhere else
blaginin · Oct 1, 2024 · 849b985 · 849b985
1 parent 8871513
commit 849b985
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 118 deletions.
diff --git a/datafusion/sqllogictest/test_files/string/dictionary_utf8.slt b/datafusion/sqllogictest/test_files/string/dictionary_utf8.slt
@@ -53,36 +53,6 @@ Xiangpeng datafusion数据融合 false true false true
 Raphael datafusionДатаФусион false false false false
 NULL NULL NULL NULL NULL NULL
 
-# TODO: move it back to `string_query.slt.part` after fixing the issue
-# see detail: https://github.com/apache/datafusion/issues/12664
-query BBBB
-SELECT
-  REGEXP_LIKE(ascii_1, 'an'),
-  REGEXP_LIKE(unicode_1, 'таФ'),
-  REGEXP_LIKE(ascii_1, NULL),
-  REGEXP_LIKE(unicode_1, NULL)
-FROM test_basic_operator;
-----
-false false NULL NULL
-true false NULL NULL
-false true NULL NULL
-NULL NULL NULL NULL
-
-# TODO: move it back to `string_query.slt.part` after fixing the issue
-# see detail: https://github.com/apache/datafusion/issues/12664
-query ????
-SELECT
-  REGEXP_MATCH(ascii_1, 'an'),
-  REGEXP_MATCH(unicode_1, 'таФ'),
-  REGEXP_MATCH(ascii_1, NULL),
-  REGEXP_MATCH(unicode_1, NULL)
-FROM test_basic_operator;
-----
-NULL NULL NULL NULL
-[an] NULL NULL NULL
-NULL [таФ] NULL NULL
-NULL NULL NULL NULL
-
 #
 # common test for string-like functions and operators
 #

diff --git a/datafusion/sqllogictest/test_files/string/string.slt b/datafusion/sqllogictest/test_files/string/string.slt
@@ -63,36 +63,6 @@ Xiangpeng datafusion数据融合 false true false true
 Raphael datafusionДатаФусион false false false false
 NULL NULL NULL NULL NULL NULL
 
-# TODO: move it back to `string_query.slt.part` after fixing the issue
-# see detail: https://github.com/apache/datafusion/issues/12664
-query BBBB
-SELECT
-  REGEXP_LIKE(ascii_1, 'an'),
-  REGEXP_LIKE(unicode_1, 'таФ'),
-  REGEXP_LIKE(ascii_1, NULL),
-  REGEXP_LIKE(unicode_1, NULL)
-FROM test_basic_operator;
-----
-false false NULL NULL
-true false NULL NULL
-false true NULL NULL
-NULL NULL NULL NULL
-
-# TODO: move it back to `string_query.slt.part` after fixing the issue
-# see detail: https://github.com/apache/datafusion/issues/12664
-query ????
-SELECT
-  REGEXP_MATCH(ascii_1, 'an'),
-  REGEXP_MATCH(unicode_1, 'таФ'),
-  REGEXP_MATCH(ascii_1, NULL),
-  REGEXP_MATCH(unicode_1, NULL)
-FROM test_basic_operator;
-----
-NULL NULL NULL NULL
-[an] NULL NULL NULL
-NULL [таФ] NULL NULL
-NULL NULL NULL NULL
-
 # TODO: move it back to `string_query.slt.part` after fixing the issue
 # see detail: https://github.com/apache/datafusion/issues/12670
 query IIIIII

diff --git a/datafusion/sqllogictest/test_files/string/string_query.slt.part b/datafusion/sqllogictest/test_files/string/string_query.slt.part
@@ -856,39 +856,35 @@ NULL NULL
 # Test REGEXP_LIKE
 # --------------------------------------
 
-# TODO: LargeString does not support REGEXP_LIKE. Enable this after fixing the issue
-# see issue: https://github.com/apache/datafusion/issues/12664
-#query BBBB
-#SELECT
-#  REGEXP_LIKE(ascii_1, 'an'),
-#  REGEXP_LIKE(unicode_1, 'таФ'),
-#  REGEXP_LIKE(ascii_1, NULL),
-#  REGEXP_LIKE(unicode_1, NULL)
-#FROM test_basic_operator;
-#----
-#false false NULL NULL
-#true false NULL NULL
-#false true NULL NULL
-#NULL NULL NULL NULL
+query BBBB
+SELECT
+  REGEXP_LIKE(ascii_1, 'an'),
+  REGEXP_LIKE(unicode_1, 'таФ'),
+  REGEXP_LIKE(ascii_1, NULL),
+  REGEXP_LIKE(unicode_1, NULL)
+FROM test_basic_operator;
+----
+false false NULL NULL
+true false NULL NULL
+false true NULL NULL
+NULL NULL NULL NULL
 
 # --------------------------------------
 # Test REGEXP_MATCH
 # --------------------------------------
 
-# TODO: LargeString does not support REGEXP_MATCH. Enable this after fixing the issue
-# see issue: https://github.com/apache/datafusion/issues/12664
-#query ????
-#SELECT
-#  REGEXP_MATCH(ascii_1, 'an'),
-#  REGEXP_MATCH(unicode_1, 'таФ'),
-#  REGEXP_MATCH(ascii_1, NULL),
-#  REGEXP_MATCH(unicode_1, NULL)
-#FROM test_basic_operator;
-#----
-#NULL NULL NULL NULL
-#[an] NULL NULL NULL
-#NULL [таФ] NULL NULL
-#NULL NULL NULL NULL
+query ????
+SELECT
+  REGEXP_MATCH(ascii_1, 'an'),
+  REGEXP_MATCH(unicode_1, 'таФ'),
+  REGEXP_MATCH(ascii_1, NULL),
+  REGEXP_MATCH(unicode_1, NULL)
+FROM test_basic_operator;
+----
+NULL NULL NULL NULL
+[an] NULL NULL NULL
+NULL [таФ] NULL NULL
+NULL NULL NULL NULL
 
 # --------------------------------------
 # Test REPEAT

diff --git a/datafusion/sqllogictest/test_files/string/string_view.slt b/datafusion/sqllogictest/test_files/string/string_view.slt
@@ -50,36 +50,6 @@ false false
 false true
 NULL NULL
 
-# TODO: move it back to `string_query.slt.part` after fixing the issue
-# see detail: https://github.com/apache/datafusion/issues/12664
-query BBBB
-SELECT
-  REGEXP_LIKE(ascii_1, 'an'),
-  REGEXP_LIKE(unicode_1, 'таФ'),
-  REGEXP_LIKE(ascii_1, NULL),
-  REGEXP_LIKE(unicode_1, NULL)
-FROM test_basic_operator;
-----
-false false NULL NULL
-true false NULL NULL
-false true NULL NULL
-NULL NULL NULL NULL
-
-# TODO: move it back to `string_query.slt.part` after fixing the issue
-# see detail: https://github.com/apache/datafusion/issues/12664
-query ????
-SELECT
-  REGEXP_MATCH(ascii_1, 'an'),
-  REGEXP_MATCH(unicode_1, 'таФ'),
-  REGEXP_MATCH(ascii_1, NULL),
-  REGEXP_MATCH(unicode_1, NULL)
-FROM test_basic_operator;
-----
-NULL NULL NULL NULL
-[an] NULL NULL NULL
-NULL [таФ] NULL NULL
-NULL NULL NULL NULL
-
 # TODO: move it back to `string_query.slt.part` after fixing the issue
 # see detail: https://github.com/apache/datafusion/issues/12670
 query IIIIII