Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: spotify scan improvements #83

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Feature: spotify scan improvements #83

wants to merge 6 commits into from
+77 −49

Conversation

gabeklavans
Copy link
Contributor

Breaking changes

  • fixed typo in env var
    • RECOMEND_GEN_SCHED -> RECOMMEND_GEN_SCHED

Features added

  • now all playlists, including private, are scanned
  • artist top playlists are not scanned/imported by default. now controlled by ARTIST_PLAYLIST_ENABLED env var
    • I think this is more in-line with the average user's expectation for a no-config set up. Most users will have a ton of artists in their library when they just want to set this up to sync the playlists they made themselves

Bugs fixed

@gabeklavans
fix: guard schedule removal/modify with existence check
c5dbb30 
also fix incorrect job ID for saved tracks job removal
@gabeklavans
comment out all recommendation playlist scan/import
81bb550 
the Spotify recommendations API is Deprecated for new apps as of Dec 2024
https://developer.spotify.com/blog/2024-11-27-changes-to-the-web-api
@gabeklavans
fix: typo in env var
b569ce0 
REQUIRES WIKI CHANGE
@gabeklavans
guard artist top track playlists with env var, default to OFF
4d0a6c4
@gabeklavans
add playlist-read-private scope to spotipy login
ab570ef 
this ensures all the user's playlists get fetched

sometimes even some public playlists don't get fetched without this scope
@gabeklavans gabeklavans changed the title Feature: spotify scan rework Feature: spotify scan improvements Dec 25, 2024
@blastbeng
Copy link
Owner

Hello and thank you for your PR, i will review this ASAP and merge if I find no issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabeklavans @blastbeng