Merge pull request #65 from bleech/harun/TestRuns

Harun/test runs
bleech · Jun 12, 2024 · ece5bd9 · ece5bd9
2 parents 1c9045f + 15c39c0
commit ece5bd9
Show file tree

Hide file tree

Showing 22 changed files with 458 additions and 116 deletions.
diff --git a/assets/admin.scss b/assets/admin.scss
@@ -1,6 +1,6 @@
 @import "@wordpress/base-styles/colors.native"; // stylelint-disable-line scss/at-import-partial-extension
 
-.vrts_list_table_page {
+.vrts-list-table-page {
 
 	.vrts-testing-status {
 		display: flex;
@@ -17,7 +17,7 @@
 		}
 
 		&--waiting {
-			color: $alert-yellow;
+			color: #F97B06;
 		}
 	}
 }

diff --git a/assets/editor.scss b/assets/editor.scss
@@ -75,7 +75,7 @@
 	}
 
 	&--waiting {
-		color: $alert-yellow;
+		color: #F97B06;
 	}
 
 	&--running {

diff --git a/components/alerts-page/_style.scss b/components/alerts-page/_style.scss
@@ -8,7 +8,7 @@ $breakpoint-mobile-horizontal: $break-mobile;
 $breakpoint-tablet: $break-medium; /* adminbar goes big */
 $navigation-item-border-height: 3px;
 
-.vrts_list_table_page {
+.vrts-list-table-page {
 
 	.alert-status {
 		display: block;

diff --git a/components/alerts-page/views/alerts-page-list.php b/components/alerts-page/views/alerts-page-list.php
@@ -1,4 +1,4 @@
-<div class="wrap vrts_list_table_page">
+<div class="wrap vrts-list-table-page">
 	<h1 class="wp-heading-inline">
 		<?php esc_html_e( 'Alerts', 'visual-regression-tests' ); ?>
 	</h1>

diff --git a/components/metabox-classic-editor/_style.scss b/components/metabox-classic-editor/_style.scss
@@ -50,7 +50,7 @@
 		}
 
 		&--waiting {
-			color: $alert-yellow;
+			color: #F97B06;
 		}
 
 		&--running {

diff --git a/components/test-runs-page/_style.scss b/components/test-runs-page/_style.scss
@@ -1,6 +1,44 @@
 @import "@wordpress/base-styles/colors.native"; // stylelint-disable-line scss/at-import-partial-extension
 @import "@wordpress/base-styles/breakpoints";
 
+.vrts-list-table-page {
+	.vrts-test-run-trigger {
+		display: inline-block;
+		border-radius: 32px;
+		padding: 4px 10px;
+		font-size: 13px;
+		background: rgba(192, 192, 192, 0.15);
+		color: $gray-80;
+
+		&--api {
+			background: rgba(224, 84, 6, 0.15);
+			color: #AE4204;
+		}
+
+		&--scheduled {
+			background: rgba(106, 26, 185, 0.1);
+			color: #591B98;
+		}
+
+		&--manual {
+			background: rgba(5, 116, 206, 0.1);
+			color: #045495;
+
+		}
+
+		&--updates {
+			background: rgba(200, 11, 147, 0.1);
+			color: #A51D7F;
+		}
+	}
+
+	.vrts-test-run-trigger-notes {
+		overflow: hidden;
+		text-overflow: ellipsis;
+		white-space: nowrap;
+	}
+}
+
 .vrts-test-runs-page {
 	.tablenav.top {
 		clear: none;
@@ -20,7 +58,7 @@
 		}
 
 		&--scheduled {
-			color: $alert-yellow;
+			color: #F97B06;
 		}
 
 		&--has-alerts {
@@ -36,46 +74,85 @@
 		color: $blue-50;
 	}
 
+	[data-vrts-test-run-status="running"] .row-title {
+		color: #F97B06;
+	}
+
 	.row-actions {
-		position: static;
+		display: flex;
+		flex-wrap: wrap;
+		gap: 4px;
 
 		.tests {
 			color: $gray-80;
 		}
-	}
 
-	.vrts-test-run-trigger {
-		display: inline-block;
-		border-radius: 32px;
-		padding: 4px 10px;
-		font-size: 13px;
+		.details {
+			visibility: hidden;
 
-		&--api {
-			background: rgba(224, 84, 6, 0.15);
-			color: #AE4204;
+			&::before {
+				content: " | ";
+			}
 		}
+	}
 
-		&--scheduled {
-			background: rgba(106, 26, 185, 0.1);
-			color: #591B98;
+	tr:hover {
+		.row-actions {
+			.details {
+				visibility: visible;
+			}
 		}
+	}
+}
 
-		&--manual {
-			background: rgba(5, 116, 206, 0.1);
-			color: #045495;
+.vrts-test-runs-list-queue-table {
+	margin-top: 10px;
+	margin-bottom: 20px;
+
+	thead,
+	tfoot {
+		display: none;
+	}
 
+	.subsubsub:has(+ &) {
+		float: none;
+	}
+}
+
+.vrts-test-run-details {
+	display: none;
+
+	[data-vrts-test-run-details="visible"] & {
+		display: block;
+	}
+
+	.vrts-test-run-details-section {
+		margin: 15px 0;
+
+		&:first-child {
+			margin-top: 25px;
 		}
 
-		&--core,
-		&--plugin {
-			background: rgba(200, 11, 147, 0.1);
-			color: #A51D7F;
+		&-title {
+			color: $alert-red;
+			font-weight: 600;
+			border-bottom: 1px solid $gray-5;
+			padding-bottom: 10px;
+			margin-bottom: 10px;
+		}
+
+		&--passed {
+			.vrts-test-run-details-section-title {
+				color: $alert-green;
+			}
+		}
+
+		ul {
+			margin: 0;
 		}
 	}
 
-	.vrts-test-run-trigger-notes {
-		overflow: hidden;
-		text-overflow: ellipsis;
-		white-space: nowrap;
+	.button {
+		margin-bottom: 4px;
 	}
 }
diff --git a/components/test-runs-page/index.php b/components/test-runs-page/index.php
@@ -1,8 +1,4 @@
-<?php
-
-?>
-
-<div class="wrap vrts_list_table_page vrts-test-runs-page">
+<div class="wrap vrts-list-table-page vrts-test-runs-page">
 	<h1 class="wp-heading-inline">
 		<?php esc_html_e( 'Runs', 'visual-regression-tests' ); ?>
 	</h1>
@@ -14,10 +10,6 @@
 	$list_table->prepare_items();
 	$list_table->views();
 	$list_table->display();
-
-	if ( $list_table->has_items() ) {
-		$list_table->inline_edit();
-	}
 	?>
 
 	<form method="post">

diff --git a/components/test-runs-page/script.js b/components/test-runs-page/script.js
@@ -0,0 +1,14 @@
+document
+	.querySelectorAll( '.vrts-show-test-run-details' )
+	.forEach( ( element ) => {
+		element.addEventListener( 'click', ( e ) => {
+			e.preventDefault();
+			const $row = element.closest( 'tr' );
+			const isHidden = $row.getAttribute( 'data-vrts-test-run-details' ) === 'hidden';
+			$row.setAttribute(
+				'data-vrts-test-run-details',
+				isHidden ? 'visible' : 'hidden'
+			);
+			console.log( 'Show test run details' );
+		} );
+	} );
diff --git a/components/tests-page/_style.scss b/components/tests-page/_style.scss
@@ -81,7 +81,7 @@
 	}
 }
 
-.vrts_list_table_page {
+.vrts-list-table-page {
 
 	.quick-edit-row-test {
 

diff --git a/components/tests-page/script.js b/components/tests-page/script.js
@@ -326,7 +326,7 @@ window.wp = window.wp || {};
 	};
 
 	$( function () {
-		if ( $( '.vrts_list_table_page' ).length ) {
+		if ( $( '.vrts-list-table-page' ).length ) {
 			inlineEditTest.init();
 		}
 	} );

diff --git a/components/tests-page/views/tests-page-list.php b/components/tests-page/views/tests-page-list.php
@@ -6,7 +6,7 @@
 
 ?>
 
-<div class="wrap vrts_list_table_page">
+<div class="wrap vrts-list-table-page">
 	<h1 class="wp-heading-inline">
 		<?php esc_html_e( 'Tests', 'visual-regression-tests' ); ?>
 	</h1>

diff --git a/includes/features/class-cron-jobs.php b/includes/features/class-cron-jobs.php
@@ -73,6 +73,12 @@ public function fetch_test_updates( $test_id, $try_number = 1 ) {
 		}
 	}
 
+	/**
+	 * Fetch test run updates.
+	 *
+	 * @param int $test_run_id Test run id.
+	 * @param int $try_number Try number.
+	 */
 	public function fetch_test_run_updates( $test_run_id, $try_number = 1 ) {
 		$test_run = Test_Run::get_item( $test_run_id );
 		if ( empty( $test_run ) || empty( $test_run->finished_at ) ) {
@@ -96,6 +102,11 @@ public static function schedule_initial_fetch_test_updates( $test_id ) {
 		wp_schedule_single_event( time(), 'vrts_fetch_test_updates', [ $test_id, 1 ] );
 	}
 
+	/**
+	 * Schedule initial fetch test run updates.
+	 *
+	 * @param int $test_run_id Test run id.
+	 */
 	public static function schedule_initial_fetch_test_run_updates( $test_run_id ) {
 		wp_schedule_single_event( time(), 'vrts_fetch_test_run_updates', [ $test_run_id, 1 ] );
 	}

diff --git a/includes/features/class-service.php b/includes/features/class-service.php
@@ -253,6 +253,7 @@ private static function get_rest_url() {
 	 * Run manual tests.
 	 *
 	 * @param string[] $service_test_ids the service test ids.
+	 * @param array    $options the options.
 	 */
 	public static function run_manual_tests( $service_test_ids, $options = [] ) {
 		$service_project_id = get_option( 'vrts_project_id' );

diff --git a/includes/features/class-settings-page.php b/includes/features/class-settings-page.php
@@ -133,29 +133,31 @@ public function add_settings() {
 			'title' => 'Test Configuration',
 		]);
 
-		vrts()->settings()->add_setting([
-			'type' => 'checkbox',
-			'id' => 'vrts_automatic_comparison',
-			'title' => esc_html__( 'Daily', 'visual-regression-tests' ),
-			'label' => esc_html__( 'Run daily scheduled tests.', 'visual-regression-tests' ),
-			'section' => 'vrts-settings-section-test-configuration',
-			'sanitize_callback' => [ Sanitization::class, 'sanitize_checkbox' ],
-			'show_in_rest' => true,
-			'value_type' => 'boolean',
-			'default' => 1,
-		]);
+		if ( '1' === $has_subscription ) {
+			vrts()->settings()->add_setting([
+				'type' => 'checkbox',
+				'id' => 'vrts_automatic_comparison',
+				'title' => esc_html__( 'Daily', 'visual-regression-tests' ),
+				'label' => esc_html__( 'Run daily scheduled tests.', 'visual-regression-tests' ),
+				'section' => 'vrts-settings-section-test-configuration',
+				'sanitize_callback' => [ Sanitization::class, 'sanitize_checkbox' ],
+				'show_in_rest' => true,
+				'value_type' => 'boolean',
+				'default' => 1,
+			]);
 
-		vrts()->settings()->add_setting([
-			'type' => 'checkbox',
-			'id' => 'vrts_updates_comparison',
-			'title' => esc_html__( 'Post-Updates', 'visual-regression-tests' ),
-			'label' => esc_html__( 'Run tests automatically after WordPress has been updated to a new version.', 'visual-regression-tests' ),
-			'section' => 'vrts-settings-section-test-configuration',
-			'sanitize_callback' => [ Sanitization::class, 'sanitize_checkbox' ],
-			'show_in_rest' => true,
-			'value_type' => 'boolean',
-			'default' => 1,
-		]);
+			vrts()->settings()->add_setting([
+				'type' => 'checkbox',
+				'id' => 'vrts_updates_comparison',
+				'title' => esc_html__( 'Post Updates', 'visual-regression-tests' ),
+				'label' => esc_html__( 'Run tests automatically after WordPress has been updated to a new version.', 'visual-regression-tests' ),
+				'section' => 'vrts-settings-section-test-configuration',
+				'sanitize_callback' => [ Sanitization::class, 'sanitize_checkbox' ],
+				'show_in_rest' => true,
+				'value_type' => 'boolean',
+				'default' => 1,
+			]);
+		}//end if
 
 		vrts()->settings()->add_setting([
 			'type' => 'text',
@@ -243,6 +245,12 @@ public function do_before_add_license_key( $new, $old ) {
 		return $old;
 	}
 
+	/**
+	 * Update automatic comparison settings for project in service
+	 *
+	 * @param string $old Old value.
+	 * @param string $new New value.
+	 */
 	public function do_after_update_vrts_automatic_comparison( $old, $new ) {
 		if ( $old !== $new ) {
 			$service_project_id = get_option( 'vrts_project_id' );