Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml for Custom Node Registry #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

haohaocreates
Copy link

@haohaocreates haohaocreates commented May 22, 2024

We are working with dr.lt.data and comfyanon to build a global registry for custom nodes (similar to PyPI). Eventually, the registry will be used as a backend for the UI-manager. All nodes go through a verification process before being published to users.

The main benefits are that authors can

  • publish nodes by version and users can safely update nodes knowing ahead of time if their workflows will break or not
  • automate testing against new commits in the comfy repo and existing workflows through our CI/CD dashboard

Action Required:

  • Go to the registry. Login and create a publisher id. Add the publisher id into the pyproject.toml file.
  • Write a short description.
  • Merge the separate Github Actions PR and run the workflow.

If you want to publish the node manually, install the cli and run comfy node publish

Check out our docs if you want to know more about the registry. Otherwise, feel free to message me on discord at haohao_81202 or join our server if you have any questions!

@haohaocreates
Copy link
Author

hey @blepping, wanted to send a small nudge and ask if you had any questions!

@haohaocreates
Copy link
Author

@blepping, wondering if there's any way we can support you on this PR!

@blepping
Copy link
Owner

blepping commented Jul 2, 2024

@haohaocreates

@blepping, wondering if there's any way we can support you on this PR!

i really apologize for the slow reply and i appreciate the offer to help! basically i can only sign up for the registry associating a github or google account and i'd only be willing to do that with a throwaway account: i don't like not being in control of how my information gets used/shared. so i need to sign up for a new email somewhere and make a new github account, basically boring administrative stuff to be able to do more boring administrative stuff. the kind of thing i love to procrastinate about, and i'm already bad about procrastination.

i plan to do it, eventually, but i am trying to finish up some other stuff first which is taking longer than expected. not sure if leaving it open is taking up brain space for you or anything, if you prefer you can close it (not saying you should or anything, totally up to you).

@haohaocreates
Copy link
Author

@haohaocreates

@blepping, wondering if there's any way we can support you on this PR!

i really apologize for the slow reply and i appreciate the offer to help! basically i can only sign up for the registry associating a github or google account and i'd only be willing to do that with a throwaway account: i don't like not being in control of how my information gets used/shared. so i need to sign up for a new email somewhere and make a new github account, basically boring administrative stuff to be able to do more boring administrative stuff. the kind of thing i love to procrastinate about, and i'm already bad about procrastination.

i plan to do it, eventually, but i am trying to finish up some other stuff first which is taking longer than expected. not sure if leaving it open is taking up brain space for you or anything, if you prefer you can close it (not saying you should or anything, totally up to you).

hey @blepping wanted to send a friendly poke to see if there is anything I could help with :)

@blepping
Copy link
Owner

blepping commented Aug 5, 2024

thanks for the offer. slowwwly making progress toward this stuff. don't worry, i didn't forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants