Skip to content

Writing a golden file test for package:flutter

Kate Lovett edited this page Jan 16, 2020 · 36 revisions

(This page is referenced by comments in the Flutter codebase.)

Golden file tests for package:flutter use Flutter Gold for baseline and version management of golden files. This allows for golden file testing on Linux, Windows, and MacOS. If you have questions about Flutter Gold, cc @Piinks on your pull request.

Index

Creating a New Golden File Test

Write your test as a normal test, using testWidgets and await tester.pumpWidget and so on.

Put a RepaintBoundary widget around the part of the subtree that you want to verify. If you don't, the output will be a 2400x1800 image, since the tests by default use an 800x600 viewport with a device pixel ratio of 3.0. If you would like to further control the image size, put a SizedBox around your RepaintBoundary to set constraints.

Add an expectation along the following lines:

  await expectLater(
    find.byType(RepaintBoundary),
    matchesGoldenFile( 'test_name.subtest.subfile.png'),
  );

The argument to matchesGoldenFile is the filename for the screen shot. The part up to the first dot should exactly match the test filename (e.g. if your test is widgets/foo_bar_test.dart, use foo_bar). The subtest part should be unique to this testWidgets entry, and the part after that should be unique within the testWidgets entry. This allows each file to have multiple testWidgets tests each with their own namespace for the images, and then allows for disambiguation within each test in case there are multiple screen shots per test.

Golden tests may be executed locally on Linux, MacOS, and Windows platforms. All reference images can be found at Flutter Gold baselines. Some tests may have multiple golden masters for a given test, to account for rendering differences across platforms. The parameter set for each image is listed in each image digest to differentiate renderings.

Once you have written your test, run flutter test --update-goldens test/foo/bar_test.dart in the flutter package directory (where the filename is the relative path to your new test). This will update the images in bin/cache/pkg/skia_goldens/packages/flutter/test/; the directories below that will match the hierarchy of the directories in the test directory of the flutter package. Verify that the images are what you expect; update your test and repeat this step until you are happy with the image.

When running flutter test locally without the --update-goldens flag, your test will pass, as it does not yet have a baseline for comparison on the Flutter Gold dashboard. The test will be recognized as new, and provide output for validation.

When you are happy with your image, you are ready to submit your PR for review. The reviewer should also verify your golden image(s), so make sure to include the golden(s) in your PR description.

New tests will initially fail pre-submit checks, the results of which will be compiled into a tryjob on the Flutter Gold dashboard, under ChangeLists. There you will see your pull request and the associated golden files that were generated.

New tests can be triaged from these tryjobs, which will allow for pre-submit tests to pass. Review the tryjob and the images that were generated, making sure they look as expected. Currently, we generate images for Linux, Mac and Windows platforms. It is common for there to be slight differences between them. Click the checkmark to approve the change, completing triage.

And that’s it! Your new golden file(s) will be checked in as the baseline(s) for your new test(s), and your PR will be ready to merge. 🎉

Triage permission is currently restricted to googlers, with plans to extend to members of flutter-hackers. For more information, see Contributor Access.

Updating a Golden File Test

If renderings change, then the golden baseline in Flutter Gold will need to be updated.

When developing your change, local testing will produce a failure along with visual diff output. This visual diff will be generated using the golden baseline from Flutter Gold that matches the current paramset of your testing environment (currently based on platform). This allows for quick iterations and validation of your change. Locally, this test will not pass until the new baseline has been checked in.

When you are happy with your golden change, you are ready to submit your PR for review. The reviewer should also verify your golden image(s), so make sure to include the golden changes you have made in your PR description. Changes to tests will initially fail pre-submit checks, the results of which will be compiled into a tryjob on the Flutter Gold dashboard, under ChangeLists. There you will see your pull request and the associated golden files that were generated, as well as the visual differences between the pre-existing baselines.

The updated tests can be triaged from these tryjobs, which will allow for pre-submit tests to pass. Review the tryjob and the images that were generated, making sure they look as expected. Currently, we generate images for Linux, Mac and Windows platforms. It is common for there to be slight differences between them. Click the checkmark to approve the change, completing triage.

Changes such as these constitute a breaking change, and should follow Handling Breaking Changes. This includes marking your PR with the severe: API break and will affect goldens labels, as well as updating the Changelog.

And that’s it! Your new golden file(s) will be checked in as the baseline(s) for your new test(s), and your PR will be ready to merge. 🎉

Triage permission is currently restricted to googlers, with plans to extend to members of flutter-hackers. For more information, see Contributor Access.

First-Time Contributors

If you are a first-time contributor making a golden file change, first of all welcome!

By following the preceding guide to golden file testing, you may have found that pre-submit testing does not generate a tryjob on the Flutter Gold dashboard. In order for Gold to authenticate during pre-submit testing, contributor permissions are also authenticated. As a first-time contributor, the necessary permissions will not be granted until you land your first change.

You can still make changes to golden files though! In this special case, cc @Piinks on your pull request for assistance. An ignore can be put in place on the Flutter Gold dashboard that is associated with the affected test(s) and pull request, making it possible to land your change. Currently, checking in golden files this way requires the assistance of a Googler, who will also need to triage the image after it lands.

Golden File Changes from flutter/engine

Currently, changes from flutter/engine require a manual roll to land so that the current engine sheriff can address the golden file changes. The changes can be viewed under ChangeLists on the Flutter Gold dashboard.

If the changes generated by the engine are not desirable, the related change that caused them will need to be reverted for the engine roll to proceed. You may mark the undesirable image results negative to prevent regressions in the future. If the changes are ok, you can mark the images positive and proceed with the roll.

The need for a manual engine roll is temporary, with resolution being tracked in this bug: https://github.com/flutter/flutter/issues/48744

Flutter Wiki

Process

Framework repo

Engine repo

Android

Plugins and packages repos

Infrastructure

Release Information

Experimental features

Clone this wiki locally