Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Video-2230] Build in Windows #13

Merged
merged 5 commits into from
Jul 14, 2023
Merged

Conversation

saraboule
Copy link

@saraboule saraboule commented Jun 30, 2023

Video-2230
During the process of developing -- https://blinemedical.atlassian.net/browse/VIDEO-2183, it was realized that the s3sink no longer built in Windows the main crux of the issue is due to the fact this PR for the aws-sdk-cpp is still open: aws/aws-sdk-cpp#1839

Currently, I am forking the aws-sdk-cpp and adding in those changes to appropriate cmake files. I was also having issues with the meson.build file -- it took in different cpp_args for Windows and in Linux. You will have to build our fork of the sdk in order to get this to build in Windows.

@saraboule
Copy link
Author

ha! looks like the preprocessor definitions I added to get this to build in Windows is causing it to fail in Ubuntu.

meson.build Outdated Show resolved Hide resolved
meson.build Outdated Show resolved Hide resolved
@saraboule saraboule marked this pull request as ready for review July 14, 2023 14:43
@saraboule saraboule requested review from a team and btgoodwin and removed request for a team July 14, 2023 14:43
somehow I accidentally overwrote this line.
@saraboule saraboule requested review from lyramcmillan and removed request for btgoodwin July 14, 2023 18:22
@saraboule saraboule merged commit 5975711 into master Jul 14, 2023
@saraboule saraboule deleted the Video-2230-build-in-Windows branch July 14, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants