Add "Get Projects" and "Find By Id" from Production Service #251
Conversation
… given project by ID. Includes the refactors and improvements that get this done
SuperJMN
force-pushed
the
get-projects
branch
from
425a423 to
f67d088
Compare
|
|
||
| public static class DependencyFactory | ||
| { | ||
| public static IRelayService GetRelayService(ILoggerFactory loggerFactory) |
There was a problem hiding this comment.
just wondering why not use the standard dependency injection?
There was a problem hiding this comment.
Good question! I chose this approach because the number of dependencies is still relatively small and adding a DI container felt like overengineering at this stage. However, if you think we should switch to standard DI, I can prepare a PR with the changes.
There was a problem hiding this comment.
yes definitely we will use DI look at the client project and how we utilize the DI there we should do the same
There was a problem hiding this comment.
I am not sure what DI you had in mind to use but the default on the web code is Microsoft.Extensions.DependencyInjection.ServiceProvider
So probably we just use the same one
There was a problem hiding this comment.
I tried to use use of Microsoft.Extensions.DependencyInjection. It's done and it works perfectly, but I think that change should be done in a follow-up PR. It's a bit of scope and I'd like to keep it separated. What do you think?
src/Angor/Avalonia/Angor.Model.Implementation/Projects/ProjectService.cs
Outdated
Show resolved
Hide resolved
| namespace Angor.Model.Implementation; | ||
|
|
||
| // TODO: This is copied from Angor.Client | ||
| public class NetworkConfiguration : INetworkConfiguration |
There was a problem hiding this comment.
hmm I dont like this, but it is temporary code then I guess it is ok for now
There was a problem hiding this comment.
Yes, that's why I decided to copy it
| public class Stage : IStage | ||
| { | ||
| public DateOnly ReleaseDate { get; set; } | ||
| public uint Amount { get; set; } |
There was a problem hiding this comment.
money we represent as long normally
There was a problem hiding this comment.
unless this is the stage representation so it is a percent in which case it should be a decimal
There was a problem hiding this comment.
It's the stage representation and it's a number in sats internally, that can be converted to whatever we need in the UI (BTC or sats)
| ); | ||
|
|
||
| lookupResultsHelper = Lookup | ||
| .ObserveOn(RxApp.MainThreadScheduler) |
There was a problem hiding this comment.
why do you need to use a schedular MainThreadScheduler? is it because there are calls over the wire?
There was a problem hiding this comment.
ViewModels needs to ensure properties are modified in the UI thread, because they are bound to the UI. Avalonia (and other GUI technologies) requires this.
But those calls to ObserveOn are not needed in this case because ReactiveUI handles this internally.
| @@ -0,0 +1,20 @@ | |||
| using AngorApp.Model; | |||
|
|
|||
| namespace Angor.Model.Implementation.Projects; | |||
There was a problem hiding this comment.
This model belongs to the UI only right? perhaps the namespace should reflect that?
There was a problem hiding this comment.
Yes, absolutely. I've modified the namespaced to reflect that.
SuperJMN
force-pushed
the
get-projects
branch
from
037f8a3 to
02df556
Compare
Implement service to get projects from the real service and to find a given project by ID.
Includes the refactors and improvements that get this done.